Skip to content

Fix: Inaccurate tool tip strings of USA Pathfinder - #2697

Open
dmgreeny wants to merge 3 commits into
TheSuperHackers:mainfrom
dmgreeny:Pathfinder-description-fix
Open

dmgreeny wants to merge 3 commits into
TheSuperHackers:mainfrom
dmgreeny:Pathfinder-description-fix

Conversation

@dmgreeny

@dmgreeny dmgreeny commented Mar 19, 2025 •

Copy link
Copy Markdown
Contributor

This change fixes the tool tip strings of the USA Pathfinder. It no longer incorrectly states that it reveals itself when shooting.

@dmgreeny dmgreeny added Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related labels Mar 20, 2025
@dmgreeny

Copy link
Copy Markdown
Contributor Author

Fixed and ready for merge

// Patch104p @fix dmgreen 27/03/2025 Changes DE, FR, ES, IT, KO, ZH, BP, PL strings to reflect US change (#2697)

// context: Appears when you mouse over the Pathfinder cameo on the USA Barracks
CONTROLBAR:ToolTipUSABuildPathFinder

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the CONTROLBAR:ToolTipGLABuildSniper? Do the same changes apply there?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTROLBAR:ToolTipGLABuildSniper
US: "Camouflaged while not moving or shooting. Spots hidden enemies\n\nStrong vs. infantry\nWeak vs. light vehicles, scouts"

Prince Kassad's snipers have correct description, as they are not revealed when they stay in one place and while shooting. Pathfinder reveals himself when he shoots.

AR: "ﺔﻳدﺎﻌﻤﻟا ةﺎﺸﻤﻟا تاﺪﺣو ﺺﻨﻘﺑ مﻮﻘﻳ\nلﻼﺧ ﻦﻣ ﻲﻔﺨﺘﻟﺎﺑ مﻮﻘﻳو\nﺺﻨﻘﻟا تﺎﯿﻠﻤﻋ وأ تﺎﺒﺴﻟا\n\nةﺎﺸﻤﻟا ﺪﺿ لﺎﻌﻓ\nﺔﻔﯿﻔﺨﻟا تﺎﺑﺮﻌﻟا ﺪﺿ ﻒﯿﻌﺿ\nﺔﻓﺎﺸﻜﻟا تاﺪﺣﻮﻟا و"
UK: "Закамуфльований, поки не рухається. Виявляє прихованих ворогів\n\nСильний проти піхоти\nСлабкий проти легкої техніки, розвідників"
US: "Camouflaged while not moving. Spots hidden enemies\n\nStrong vs. infantry\nWeak vs. light vehicles, scouts"
DE: "Getarnt im Stand. Erkennt versteckte Feinde\n\nStark gegen Infanterie\nSchwach gegen leichte Fahrzeuge, Späher"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the way this was changed is not optimal. In English, it removes a part of the sentence. The same can be done for the other languages.

So
DE would change to "Ist für seine Gegner nur sichtbar, wenn er sich bewegt. [...]"
FR would change to "Camouflé lorsqu'il est immobile. [...]"
...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

---
date: 2025-03-27

title: Changes Pathfinder unit description

@xezon xezon Apr 17, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes inaccurate tool tip strings of USA Pathfinder


title: Changes Pathfinder unit description


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 1 blank line.



changes:
- fix: Improved text description for Pathfinder unit

@xezon xezon Apr 17, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- fix: The tool tip strings of the USA Pathfinder no longer incorrecly claim that the unit is revealed when shooting.

changes:
- fix: Improved text description for Pathfinder unit

subchanges:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused field.

@xezon xezon Apr 17, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yaml files are all lower case.

name this _pathfinder_tooltip because this is how we named other tool tip related yaml files.


labels:
- minor
- text

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usa

@xezon xezon added the USA Affects USA faction label Apr 17, 2025
@xezon xezon changed the title Pathfinder description fix Fix: Inaccurate tool tip strings of USA Pathfinder for all languages Apr 17, 2025
@xezon xezon changed the title Fix: Inaccurate tool tip strings of USA Pathfinder for all languages Fix: Inaccurate tool tip strings of USA Pathfinder Apr 17, 2025
BP: "Camuflado enquanto não se move. Detecta inimigos escondidos\n\nForte vs. infantaria\nFraco vs. veículos leves, batedores"
PL: "Zamaskowany, gdy się nie porusza. Wykrywa ukrytych wrogów\n\nSilny przeciwko piechocie\nSłaby przeciwko lekkim pojazdom, zwiadowcom"
RU: "Замаскирован, пока не движется. Обнаруживает замаскированные объекты и войска\n\nСилён против пехоты\nСлаб против легкой техники, разведчиков"
AR: "Camouflaged while not moving. Spots hidden enemies\n\nStrong vs. infantry\nWeak vs. light vehicles, scouts"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason changing the Arabic string? would we not want it to be in Arabic just change the description if it's incorrect.

Example text for Arabic needs checked by a native speaker could be nonsense as far as i know: ﻣُﺘﻤﻮﻫ ﻋﻨﺪﻣﺎ ﻻ ﻳﺘﺤﺮﻙ\nﻳﻜﺘﺸﻒ ﺍﻷﻋﺪﺍء ﺍﻟﻤﺨﺘﺒﺌﻴﻦ\n\nﻗﻮﻱ ﺿﺪ ﺍﻟﻤﺸﺎﺓ\nﺿﻌﻴﻒ ﺿﺪ ﺍﻟﻌﺮﺑﺎﺕ ﺍﻟﺨﻔﻴﻔﺔ، ﺍﻟﻜﺸﺎﻓﺔ

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to not touch Arabic at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related USA Affects USA faction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants