Repository navigation
Conversation
|
Fixed and ready for merge |
| // Patch104p @fix dmgreen 27/03/2025 Changes DE, FR, ES, IT, KO, ZH, BP, PL strings to reflect US change (#2697) | ||
|
|
||
| // context: Appears when you mouse over the Pathfinder cameo on the USA Barracks | ||
| CONTROLBAR:ToolTipUSABuildPathFinder |
There was a problem hiding this comment.
What about the CONTROLBAR:ToolTipGLABuildSniper? Do the same changes apply there?
There was a problem hiding this comment.
CONTROLBAR:ToolTipGLABuildSniper
US: "Camouflaged while not moving or shooting. Spots hidden enemies\n\nStrong vs. infantry\nWeak vs. light vehicles, scouts"
Prince Kassad's snipers have correct description, as they are not revealed when they stay in one place and while shooting. Pathfinder reveals himself when he shoots.
| AR: "ﺔﻳدﺎﻌﻤﻟا ةﺎﺸﻤﻟا تاﺪﺣو ﺺﻨﻘﺑ مﻮﻘﻳ\nلﻼﺧ ﻦﻣ ﻲﻔﺨﺘﻟﺎﺑ مﻮﻘﻳو\nﺺﻨﻘﻟا تﺎﯿﻠﻤﻋ وأ تﺎﺒﺴﻟا\n\nةﺎﺸﻤﻟا ﺪﺿ لﺎﻌﻓ\nﺔﻔﯿﻔﺨﻟا تﺎﺑﺮﻌﻟا ﺪﺿ ﻒﯿﻌﺿ\nﺔﻓﺎﺸﻜﻟا تاﺪﺣﻮﻟا و" | ||
| UK: "Закамуфльований, поки не рухається. Виявляє прихованих ворогів\n\nСильний проти піхоти\nСлабкий проти легкої техніки, розвідників" | ||
| US: "Camouflaged while not moving. Spots hidden enemies\n\nStrong vs. infantry\nWeak vs. light vehicles, scouts" | ||
| DE: "Getarnt im Stand. Erkennt versteckte Feinde\n\nStark gegen Infanterie\nSchwach gegen leichte Fahrzeuge, Späher" |
There was a problem hiding this comment.
I think the way this was changed is not optimal. In English, it removes a part of the sentence. The same can be done for the other languages.
So
DE would change to "Ist für seine Gegner nur sichtbar, wenn er sich bewegt. [...]"
FR would change to "Camouflé lorsqu'il est immobile. [...]"
...
| --- | ||
| date: 2025-03-27 | ||
|
|
||
| title: Changes Pathfinder unit description |
There was a problem hiding this comment.
Fixes inaccurate tool tip strings of USA Pathfinder
|
|
||
| title: Changes Pathfinder unit description | ||
|
|
||
|
|
|
|
||
|
|
||
| changes: | ||
| - fix: Improved text description for Pathfinder unit |
There was a problem hiding this comment.
- fix: The tool tip strings of the USA Pathfinder no longer incorrecly claim that the unit is revealed when shooting.
| changes: | ||
| - fix: Improved text description for Pathfinder unit | ||
|
|
||
| subchanges: |
There was a problem hiding this comment.
The yaml files are all lower case.
name this _pathfinder_tooltip because this is how we named other tool tip related yaml files.
|
|
||
| labels: | ||
| - minor | ||
| - text |
| BP: "Camuflado enquanto não se move. Detecta inimigos escondidos\n\nForte vs. infantaria\nFraco vs. veículos leves, batedores" | ||
| PL: "Zamaskowany, gdy się nie porusza. Wykrywa ukrytych wrogów\n\nSilny przeciwko piechocie\nSłaby przeciwko lekkim pojazdom, zwiadowcom" | ||
| RU: "Замаскирован, пока не движется. Обнаруживает замаскированные объекты и войска\n\nСилён против пехоты\nСлаб против легкой техники, разведчиков" | ||
| AR: "Camouflaged while not moving. Spots hidden enemies\n\nStrong vs. infantry\nWeak vs. light vehicles, scouts" |
There was a problem hiding this comment.
What was the reason changing the Arabic string? would we not want it to be in Arabic just change the description if it's incorrect.
Example text for Arabic needs checked by a native speaker could be nonsense as far as i know: ﻣُﺘﻤﻮﻫ ﻋﻨﺪﻣﺎ ﻻ ﻳﺘﺤﺮﻙ\nﻳﻜﺘﺸﻒ ﺍﻷﻋﺪﺍء ﺍﻟﻤﺨﺘﺒﺌﻴﻦ\n\nﻗﻮﻱ ﺿﺪ ﺍﻟﻤﺸﺎﺓ\nﺿﻌﻴﻒ ﺿﺪ ﺍﻟﻌﺮﺑﺎﺕ ﺍﻟﺨﻔﻴﻔﺔ، ﺍﻟﻜﺸﺎﻓﺔ
There was a problem hiding this comment.
I suggest to not touch Arabic at all.
This change fixes the tool tip strings of the USA Pathfinder. It no longer incorrectly states that it reveals itself when shooting.