Skip to content

Swap skinned mesh from another slot / Unswap skinned mesh#1168

Open
Stranger1992 wants to merge 11 commits into
developfrom
Skinned-Mesh-Nodes
Open

Swap skinned mesh from another slot / Unswap skinned mesh#1168
Stranger1992 wants to merge 11 commits into
developfrom
Skinned-Mesh-Nodes

Conversation

@Stranger1992

Copy link
Copy Markdown
Member

This pull request adds new functionality to allow swapping and unswapping of skinned meshes on moveable objects in the engine. Two new functions are introduced: one to swap the skinned mesh from another slot, and another to revert the swap and restore the original mesh.

New moveable skinned mesh management functions:

  • Added SwapSkinnedMesh function to LevelFuncs.Engine.Node, enabling the replacement of a moveable's skinned mesh with another, optionally specifying a mesh index for cases with multiple skinned meshes in a single slot.
  • Added UnswapSkinnedMesh function to LevelFuncs.Engine.Node, allowing the restoration of the original skinned mesh by undoing any previous swaps.

@Stranger1992 Stranger1992 added Tomb Editor nodes Task specific to TEN Nodes. ready for review The Pull Request is finished and ready for review. labels Mar 26, 2026
Copilot AI review requested due to automatic review settings March 26, 2026 03:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds scripting-level support for swapping a moveable’s skinned mesh from another WAD slot and restoring the original skinned mesh afterward.

Changes:

  • Added LevelFuncs.Engine.Node.SwapSkinnedMesh(moveable, target, mesh) to swap a moveable’s skinned mesh (optionally selecting a mesh index).
  • Added LevelFuncs.Engine.Node.UnswapSkinnedMesh(moveable) to revert a prior skinned mesh swap.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua
Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua
Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua
Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua Outdated
Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua
Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua Outdated
Stranger1992 and others added 3 commits March 26, 2026 03:09
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua Outdated
Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua Outdated
Stranger1992 and others added 4 commits April 22, 2026 11:34
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mov:HideInteractionHighlight()
end

-- !Name "Swap skinned mesh from another slot."

Copilot AI Apr 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!Name strings in this catalog don’t appear to use trailing periods (they use either no punctuation or ...). For consistency in the node list, consider removing the trailing . here.

Copilot uses AI. Check for mistakes.
Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua Outdated
Comment thread TombLib/TombLib/Catalogs/TEN Node Catalogs/Moveables.lua Outdated
Stranger1992 and others added 2 commits April 22, 2026 11:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Stranger1992
Stranger1992 requested a review from Copilot April 22, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Installer/Changes.txt
Comment on lines 15 to +16
* Added a node to unswap a previously swapped mesh.
* Added nodes to swap and restore skinned meshes.

Copilot AI Apr 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes under “TEN nodes” now have a specific bullet about unswapping meshes and a second bullet about swapping/restoring skinned meshes, which overlaps with the first and can read redundant. Consider consolidating into a single bullet that covers both swap and unswap/restore to keep the changelog concise and unambiguous.

Suggested change
* Added a node to unswap a previously swapped mesh.
* Added nodes to swap and restore skinned meshes.
* Added nodes to swap and unswap meshes, including restoring skinned meshes.

Copilot uses AI. Check for mistakes.
@Stranger1992 Stranger1992 self-assigned this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The Pull Request is finished and ready for review. Tomb Editor nodes Task specific to TEN Nodes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants