Swap skinned mesh from another slot / Unswap skinned mesh#1168
Swap skinned mesh from another slot / Unswap skinned mesh#1168Stranger1992 wants to merge 11 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds scripting-level support for swapping a moveable’s skinned mesh from another WAD slot and restoring the original skinned mesh afterward.
Changes:
- Added
LevelFuncs.Engine.Node.SwapSkinnedMesh(moveable, target, mesh)to swap a moveable’s skinned mesh (optionally selecting a mesh index). - Added
LevelFuncs.Engine.Node.UnswapSkinnedMesh(moveable)to revert a prior skinned mesh swap.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…mb-Editor into Skinned-Mesh-Nodes
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mov:HideInteractionHighlight() | ||
| end | ||
|
|
||
| -- !Name "Swap skinned mesh from another slot." |
There was a problem hiding this comment.
!Name strings in this catalog don’t appear to use trailing periods (they use either no punctuation or ...). For consistency in the node list, consider removing the trailing . here.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Added a node to unswap a previously swapped mesh. | ||
| * Added nodes to swap and restore skinned meshes. |
There was a problem hiding this comment.
Release notes under “TEN nodes” now have a specific bullet about unswapping meshes and a second bullet about swapping/restoring skinned meshes, which overlaps with the first and can read redundant. Consider consolidating into a single bullet that covers both swap and unswap/restore to keep the changelog concise and unambiguous.
| * Added a node to unswap a previously swapped mesh. | |
| * Added nodes to swap and restore skinned meshes. | |
| * Added nodes to swap and unswap meshes, including restoring skinned meshes. |
This pull request adds new functionality to allow swapping and unswapping of skinned meshes on moveable objects in the engine. Two new functions are introduced: one to swap the skinned mesh from another slot, and another to revert the swap and restore the original mesh.
New moveable skinned mesh management functions:
SwapSkinnedMeshfunction toLevelFuncs.Engine.Node, enabling the replacement of a moveable's skinned mesh with another, optionally specifying a mesh index for cases with multiple skinned meshes in a single slot.UnswapSkinnedMeshfunction toLevelFuncs.Engine.Node, allowing the restoration of the original skinned mesh by undoing any previous swaps.