Standardize export sheet name - #2
Open
reilly-webster wants to merge 7 commits into
Open
Conversation
| }, | ||
| header, | ||
| sheetName | ||
| } as any, |
Collaborator
There was a problem hiding this comment.
Do we just need to update the config type to include sheetName as an available config field so we don't need any?
| }, | ||
| header, | ||
| sheetName | ||
| } as any, |
| header | ||
| }, | ||
| header, | ||
| sheetName |
Collaborator
There was a problem hiding this comment.
We probably also need a pull request to the studio backend bundle to also use this sheetname param.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for specifying a custom sheet name when exporting data to XLSX files and updates related UI and backend logic. It also includes minor improvements to translation strings for consistency.
XLSX Export Enhancements:
sheetNamefield to the XLSX export form, allowing users to specify the name of the sheet in the exported file (create-xlsx-form.tsx,XLSXFormValues) [1] [2].sheetNamefield with a default value (Sheet1) and to pass this value through the export job and backend request (xlsx-modal.tsx) [1] [2] [3] [4].studio.en.yaml).Translation and Formatting Improvements:
studio.en.yaml) [1] [2].## Changes in this pull request