Initial cleanup notes

[zippy1981]

I'm trying to get hammerdb running on my laptop so I can test this. However, having looked at the code, the following needs to be done:

• DB access needs to be moved outside of the windorm classess and possible into a separate DLL
• using() blocks need to be utilised for the SqlCommand and SqlReader objects.
• SqlCommand.Parameters.AddWithValue() should be used
• Thread.Start() should never be called. Task parallel library should be used

My first code commit will probably include the last three things.

[sqlchow]

I have a DB access class that I got a while ago. I can add that to the project.

Sent from my Windows Phone

---

From: Justin Dearingmailto:notifications@github.com
Sent: ‎04-‎10-‎2014 09:44
To: TrackMyQuery/TrackMyQuerymailto:TrackMyQuery@noreply.github.com
Subject: [TrackMyQuery] Initial cleanup notes (#2)

I'm trying to get hammerdb running on my laptop so I can test this. However, having looked at the code, the following needs to be done:

• DB access needs to be moved outside of the windorm classess and possible into a separate DLL
• using() blocks need to be utilised for the SqlCommand and SqlReader objects.
• SqlCommand.Parameters.AddWithValue() should be used
• Thread.Start() should never be called. Task parallel library should be used

My first code commit will probably include the last three things.

---

Reply to this email directly or view it on GitHub:
#2

[sqlchow]

• DB access needs to be moved outside of the windorm classess and possible into a separate DLL

Added the class and submitted pull request.

Since, I am new to Git; I have been submitting changes via master. For the future, I will use a branch other than master to submit changes.

[MatanYungman]

Everything you noted makes sense guys. Those are just things I didn't have time to polish