Skip to content

fix(cli): handle Supervisor key releases and command-search input - #1669

Merged
luokerenx4 merged 1 commit into
devfrom
codex/fix-supervisor-key-events
Sep 30, 2026
Merged

luokerenx4 merged 1 commit into
devfrom
codex/fix-supervisor-key-events

Conversation

@luokerenx4

@luokerenx4 luokerenx4 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

The CLI Supervisor handled Kitty key release events in its raw input listener before pi-tui's focused-component release filter. A Down press followed by release moved selection twice, and an Esc release could detach after its press closed Commands. Consume releases at the Supervisor input boundary while preserving press/repeat behavior.

Command search now matches enhanced Backspace and Ctrl+U sequences and accepts complete bracketed paste as single-line search text. Pasted control sequences remain rejected and pasted text does not execute shortcuts. The generic Workspace xterm, WebSocket/IPC, and PTY transport are unchanged.

Validation:

  • CLI typecheck and git diff --check passed.
  • All three Supervisor test files passed: 157 tests, including real pi-tui framing/matching/modal routing and an actual PTY regression that negotiates Kitty flags, pastes into Commands, closes with Esc press/release, and proves the session remains usable.
  • The four new protocol tests fail on the untouched dev baseline and pass with this fix.
  • Full CLI package suite passed with a test-subprocess umask of 022: 76 files passed, 789 tests passed, 1 skipped. The earlier installer assertion failure was caused by this environment's inherited umask 0077: the fixture's default-created index.html already had mode 0600, so chmod(0600) did not alter it. The same assertion passes on untouched dev under umask 022. No system security settings or installer production code were changed.
  • Exact head ec43142 passed Dev PR Clean Build #369: CI workflow contracts and complete workspace build succeeded. Vercel status also succeeded.
  • Local PTY testing required compiling the installed node-pty source against Node-API headers because the environment proxy blocks nodejs.org header downloads. Native Windows PTY execution was not tested.

Based on dev commit 48cdb0f, including notification PR #1668. Draft for review; no merge or release.

@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
openalice-demo Ready Ready Preview Sep 30, 2026 6:57am UTC

Request Review

@luokerenx4
luokerenx4 marked this pull request as ready for review September 30, 2026 18:43
@luokerenx4
luokerenx4 merged commit 456a689 into dev Sep 30, 2026
3 checks passed
@luokerenx4
luokerenx4 deleted the codex/fix-supervisor-key-events branch September 30, 2026 18:43

This branch was successfully deployed

1 active deployment
Preview — ec43142f Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants