Repository navigation
feat(desktop): Journal-driven companion bubbles and notification preferences - #1676
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
luokerenx4
marked this pull request as ready for review
September 30, 2026 18:51
This was referenced Sep 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop users receive meaningful ProductActivityJournal announcements on the main window or an already-visible background companion. Settings → Pet exposes explicit persisted switches: completion/Inbox, failure, action needed and news initially on; routine progress off. The former preset selector and Use preset semantics are removed. Migration expands saved preset choices then applies Show/Hide overrides, independently of master/pause. Reset restores event values while preserving enabled, pause, surface and privacy state. Journal/Office remain complete.
Included increments:
e23ea123).6ae072168701eaf7e12094ceac3ac4f834dfdf9e): HTTP restart fixture prevents global-fetch stale keep-alive reuse through its supported fetch override; production UTA POST/retry behavior unchanged. Execution shutdown during a launched child’s running projection retains the completion result for dispatch persistence instead of throwing the post-launch abort. Deterministic regression fails on baseline and passes after the fix.PRD/acceptance: plans/companion-activity-notifications.md. Existing layout, Toggle primitive, labels and narrow wrapping controls are reused. Actual /settings/pet walkthrough with production preference store through an isolated browser bridge verifies initial values, edit/reload and reset preserving disabled master/pause. Inspected desktop/narrow captures; desktop capture saved to Library libfile_4b7774077240819191b009eaa0372d8d. Native Linux demo acceptance from initial implementation is recorded in the plan; macOS/Windows physical compositor acceptance remains unverified.
Verification: 20 focused notification tests and 106 desktop owner tests previously passed; blocker fixes pass entire immutable test:critical gate and 22 lifecycle/progress tests. Root/UI/desktop types pass after latest dev sync (including merged #1674 targeted-feedback guidance). Delivery full-suite rerun completed because cumulative branch crosses desktop/UI and shared lifecycle: 874 files / 7429 tests passed; 3 baseline process-cleanup assertions failed, native PTY collection failed, 1 file / 5 tests skipped. These same failures reproduce on dev, with cleanup survivors observed as PID-1 zombies; no new regressions found. System Git, writable npm cache and umask 022 resolved the other prior environment failures. Prior run: 7374 passed / 45 failed; 41 were resolved by system Git/writable npm cache and the installer fixture passed under umask 022. The original HTTP CI failure reproduced on dev with zero requests reaching restarted server; fixture-only Connection: close experiment passed 35 tests including 30 restart cases.
Exact-head CI: run 36761120532 completed successfully at 6ae0721: workflow contracts, required critical-local receipt and complete workspace build all pass. Vercel status also succeeds. Original failed runs are diagnostic history, not current acceptance. User has authorized resolving blockers and normal merge into dev when verified. No release, credentials, live trading or Mac installation. No production trading changes.