Skip to content

fix: restore Supervisor lifecycle evidence and editable selection - #1682

Merged
luokerenx4 merged 3 commits into
devfrom
codex/lifecycle-fixture-evidence
Oct 1, 2026
Merged

luokerenx4 merged 3 commits into
devfrom
codex/lifecycle-fixture-evidence

Conversation

@luokerenx4

@luokerenx4 luokerenx4 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Problem and resulting behavior

Merged dev exposed 22 failures in the 60-case Supervisor PTY file and a permission-corruption fixture that was a no-op under umask 0077. Actual TUI regressions treated internal presentation selection as a CLI override, reread Setup without its selected context when Default was null, and marked a missing Home available whenever its Runtime endpoint was live.

Use caller-owned temporary fixture Homes; complete the current relay invocation API and model synthetic successful Default persistence; clear inherited real-CLI Home/Project overrides. Preserve ordinary selection provenance, keep unavailable Default detached, reread the current context after Setup saves, and keep endpoint liveness independent from Home availability. New component regressions fail against unchanged dev product code and pass after repair. Installer mode corruption differs from the extracted original mode under both umasks; permission and subsequent content-integrity rejection remain independent. No installer product change, deleted assertion, added skip or timeout increase.

Executable grouping and related increments

Startup-project-selection, update-recovery and persisted-state manifests reference named real terminal/settings/installer claims. This PR expands startup from 5 to 6 files, executing 198 tests including all 60 PTY cases. Metadata names bounded claims; execution remains file-granular, with synthetic Runtime success separate from real loopback identity verification.

Physical organization follows in #1684, which includes these exact prerequisite commits and then splits the 60 cases into four files with shared support. Desktop group completion is independent #1683. Both target dev as Drafts. No merge/release.

Validation

  • Startup: 6 files /198 passed (32.96s); all 60 real PTY cases. Three new component regressions fail on old product source and pass on the repair. Two terminal quit guards passed targeted checks, preventing repeated writes after descriptor closure.
  • Installer: 29 passed, one existing macOS-only exclusion under both umask 0077 and 0022. No integrity check weakened.
  • Runtime/CLI owner: 195 files /1954 passed, two existing exclusions (61.71s). Workflow contracts: 12 files /108 passed. Entire critical gate accepted: 15 required references /18 expanded tests. Root, CLI, UI and central typechecks passed.
  • Combined fix: restore Supervisor lifecycle evidence and editable selection #1682 + fix: retain live Desktop smoke groups and accept exited zombies #1683 + physical split backstop at local source 95243a51: 884 files passed, one existing excluded file; 7540 tests passed, five existing exclusions, zero failures (362.65s). This source snapshot precedes fix(desktop): avoid destroyed-window exception on notification shutdown #1685. Its unrelated notification delta passed separately with the process helpers (24 tests), and refreshed head CI below covers the new base.
  • Installed dugite Git (LOCAL_GIT_DIRECTORY=/usr/local, GIT_EXEC_PATH=/usr/local/libexec/git-core) and writable npm cache are host prerequisites. Initial missing-Git critical attempt and aborted incomplete-worktree dependency run are not acceptance. Neither failure was skipped or repaired in product code.

Final head a27ae3d38760084aeebda3d2d33c22a04cb07fae integrates current dev a8c9f705: Dev PR Clean Build 36805539905 completed successfully, including workflow contracts, whole critical gate and complete workspace build. Critical receipt artifact 11137063730 is confirmed tied to this exact SHA.

Commands: pnpm test:select --scenario startup-project-selection; pnpm test:select --scenario update-recovery --path packages/cli/src/install.spec.mjs; pnpm test:owner:runtime-cli; pnpm test:critical. Append --list --explain for dry runs. Static import selection does not cross spawned PTY entry paths: select affected owner/scenario/protocol explicitly. Native Electron binary is absent here; Windows/macOS terminals, installed signed launchers, actual SSH/Docker installer and native artifact acceptance remain unverified.

Authorized merge and integrated check

With explicit maintainer authorization, normal expected-head guarded merge produced b072cfa747af96318a74c878044df54696689aaf. No bypass, force push or release. Final integrated dev 3542ea0afc721f3d351a56065ad93571a79a9f38 contains all three exact feature heads. Its code/test/metadata tree matches the already validated combination; only final acceptance documentation differs. Postmerge checks: startup + Desktop 15 files /205 passed, Guardian 6 /67, terminal presentation 1 /29, workflow 12 /108. All selector receipts are accepted at this clean exact merged source. Terminal presentation emitted four EBADF warnings from repeated exit-phase fixture writes; assertions and receipts pass, and this bounded merge does not hide or repair them.

This final CI clean-build job's log timestamp execution window was 163.965 seconds (queue excluded). The earlier 362.65 seconds was the local complete hermetic suite, not this CI pipeline.

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
openalice-demo Ready Ready Preview Oct 1, 2026 2:22am UTC

Request Review

@luokerenx4
luokerenx4 marked this pull request as ready for review October 1, 2026 02:39
@luokerenx4
luokerenx4 merged commit b072cfa into dev Oct 1, 2026
3 checks passed
@luokerenx4
luokerenx4 deleted the codex/lifecycle-fixture-evidence branch October 1, 2026 02:39

This branch was successfully deployed

1 active deployment
Preview — a27ae3d3 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants