Repository navigation
fix(news): match complete ticker tokens in Symbol filters - #1743
Draft
luokerenx4 wants to merge 1 commit into
Draft
luokerenx4 wants to merge 1 commit into
luokerenx4 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
News → Symbol currently returns ordinary words for short tickers:
Fmatches “Fed cuts rates”. This Draft fixes only the production and demo list filters for #1387; Keyword search remains a substring search.Review order: 1 of 2. This PR remains based on
devat head232c6f0a661881a7cf4bd8a61441b72191da2a36. Dependent Draft #1755 now targetscodex/news-symbol-boundariesand includes this exact commit. Review this ticker-boundary fix first, then #1755's provenance delta; its combined head isd93911d1fd4d7e4c85711dddd4ce7de4c439ef22. Both original intents remain separately reviewable and the overlapping predicates are already reconciled.The existing routes keep ownership of filtering before the result limit. Replace their Symbol substring check with a small Unicode-aware token comparison; retain dots, hyphens, slashes, colons, carets and equals inside ticker tokens. No registry, company inference, provider request, or persisted state is added. The demo mirrors the same rule.
Tradeoff: this is lexical matching, not evidence of a company association. A standalone ordinary word equal to a ticker can still match. Case-insensitive behavior remains intentional. Feed/tag provenance is separately assigned to #1380/#1381.
Validation:
git diff --checkpassed.Four files, 44 insertions / 2 deletions. Based on current dev
4813c1b89d8c151a7853f717e31629f3ec1f3b4c. No merge, release, deployment or issue closure requested.Pushed head
232c6f0a661881a7cf4bd8a61441b72191da2a36verified against the remote branch. GitHubclean-buildpassed on that SHA.Stack acceptance: #1755's four combined regression cases run against both production and demo. Deliberately restoring substring matching makes all four fail; restoring source/unknown category evidence also makes all four fail. The intended integrated tree passes 137 focused tests plus root, UI and registered-suite typechecks. The child head
d93911d1fd4d7e4c85711dddd4ce7de4c439ef22passed clean-build and the integrated Chromium Symbol/Keyword check. CI and verification details are recorded on #1755.When accepted, integrate #1743 first while preserving its commit ancestry, then retarget #1755 to
dev. Do not take either old predicate wholesale or cherry-pick a conflicting standalone patch: the child branch already contains the resolved composition. Neither PR has been merged.