Repository navigation
test(workspaces): await final Issue handoff cleanup - #1745
Draft
luokerenx4 wants to merge 1 commit into
Draft
luokerenx4 wants to merge 1 commit into
luokerenx4 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue handoff integration test intermittently fails even though completion cleanup is still progressing normally. This is #1461's test synchronization defect, not evidence that users lose the resume lease. Scope: one test file, both existing terminal and web-session cases.
sequenceDiagram participant Runtime as Existing Workspace runtime participant Test as Handoff test Runtime->>Test: Task status becomes done Note over Runtime: Completion bookkeeping still pending Note over Test: Before FAIL assumes done means lease released Runtime->>Runtime: Finish bookkeeping and release active resume lease Test->>Runtime: After observe done plus paused plus inactive together Runtime-->>Test: Final cleanup invariant satisfiedReuse the existing bounded
vi.waitForand its unchanged 10-second budget to observe the complete invariant. Remove the immediate state/lease checks that ran after observing only task output status. Retain takeover approval, blocked competing dispatch and stop-order assertions. No production lifecycle, lease timing, persistence or new completion abstraction.Tradeoff: this tests eventual cleanup, not that
doneis a cleanup barrier; current source explicitly publishes it earlier. The same bounded wait fails if the lease never clears.Validation on Linux / Node 24.19.0, dev
4813c1b8:Draft for review; no merge or issue closure. CI is reported against the pushed SHA separately.
Included increment:
079bafa7— Observe task completion, paused session and lease release together.Boundary touch: tests only. Production runtime, permissions, trading, credentials, persistence and packaging are unchanged. Non-goals include unrelated sidebar work and dual-sided/hedge position design.
Verified pushed head:
079bafa7b783c2cb610b3bfe87f8e5b533661227. Dev PR clean-build: SUCCESS.