[DX-1107] Sync fork with upstream getsentry v4.0.0 - #24
Conversation
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.0 to 7.25.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.25.6/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.9...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update octokit version * Update README.md
* Modernize to ESM, Node 24, and latest deps; mask private key - Mask private key via core.setSecret() to prevent leaking in error logs - Convert to native ESM (type: module, nodenext) - Upgrade action runtime to node24 - Upgrade all deps to latest (octokit 8/22, actions/core 3, TS 5.9, ESLint 10, Jest 30, Prettier 3) - Migrate ESLint to flat config, remove redundant rules covered by recommendedTypeChecked - Consolidate config: jest/prettier inline in package.json, remove husky/lint-staged - Add test suite covering secret masking, scoping, error handling - Remove unused deps (js-yaml, eslint-config-sentry, eslint-plugin-github) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Upstream already runs on the node24 runtime. Our only local content was CODEOWNERS, so the merge takes upstream package.json and yarn.lock whole. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
They authenticate as getsentry's GitHub App and check out getsentry/action-github-app-token-test. This fork has no Actions secrets and no access to that repo, so both steps can never pass here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1df2531 to
bf5cec6
Compare
AI PR Review
💬 Manual DEVEX review required — unsupported file type(s): This change merges the action-github-app-token fork with upstream v4.0.0, moving Node 20 to Node 24 and bumping many dependencies to new major versions. Some files have no matching skill and several manifest and workflow files need human review because of the major bumps. Detailed findings
Changes (14 files)
Why this verdict💬 Manual DEVEX review required
Skills available
File categories not listed above are unsupported and require manual review. Add a skill module under 🤖 Generated by ai-pr-review — review limited to files owned by @TransferGo/devex. This comment is updated in place on every commit; approvals are automatically dismissed and re-evaluated when new commits land. |
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 |
There was a problem hiding this comment.
suggestion: Confirm the pinned commit SHA for actions/checkout matches the v4 tag before merge. A wrong SHA will pin the workflow to the wrong commit.
| "@actions/core": "^1.10.1", | ||
| "@octokit/auth-app": "^6.0.3", | ||
| "@octokit/rest": "^20.0.2" | ||
| "@actions/core": "^3.0.0", |
There was a problem hiding this comment.
suggestion: The bump of @actions/core from ^1.10.1 to ^3.0.0 skips two major versions. Verify this version exists and check the changelog for breaking API changes.
Task DX-1107
Problem
This action declares
runs.using: node20. GitHub removes Node 20 from the runners on 2026-09-16.Solution
Merged upstream
getsentry/action-github-app-token@v4.0.0, which already runsnode24. Our fork held no functional patch, onlyCODEOWNERS, sopackage.jsonandyarn.lockare taken from upstream whole. The tree now matches upstream v4.0.0 plusCODEOWNERS.action.ymlchanges by one line,node20tonode24. Inputs and outputs are unchanged, so consumers need only a version bump.Testing
yarn testpasses, 9 tests, on Node 24.15.0. No tag yet, and no consumer bumps in this PR.