docs: record that plain Train keeps an overridable Run - #60
Merged
Merged
Conversation
A plain Train subclass can override Run and never reach Junctions(), so the chain DeclaredChain() reads is not the one that runs. That stays: plain Train is the base for Core-only consumers, and published Trax.Effect overrides Run in ServiceTrain against a minimum Core version, so a non-virtual Run would stop every published ServiceTrain loading. ADR 0003 records the decision and the rejected options, the Train and Run XML docs state the consequence, and PlainTrainRunStaysVirtualTests pins the modifier.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
This PR is included in version 1.7.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plain Train subclass can override Run and never reach Junctions(), so the chain DeclaredChain() reads is not the one that runs. That stays: plain Train is the base for Core-only consumers, and published Trax.Effect overrides Run in ServiceTrain against a minimum Core version, so a non-virtual Run would stop every published ServiceTrain loading. ADR 0003 records the decision and the rejected options, the Train and Run XML docs state the consequence, and PlainTrainRunStaysVirtualTests pins the modifier.