fix: narrow public surface - #66
Merged
Merged
Conversation
LoggerExtensions, MoqExtensions, MonadExtensions and MonadTaskExtensions were public only by accident. They are the reflection helpers and Memory plumbing behind Monad's chain calls; nothing outside Trax.Core calls them, and because they live in Trax.Core.Extensions (the namespace consumers import for AssertLoaded) their extension methods showed up on every ILoggerFactory, every Monad and, for GetMockedTypeFromObject, every object. They are now internal, as are Junction.ExceptionData, Junction.PreviousResult and the ChainRecorder constructor, which only Trax.Core itself reads or calls. RailwayJunction stays public because Trax.Effect overrides it, but it is now hidden from completion on both Junction and IJunction. Junction.Result stays public: Trax.Effect's junction logger reads it. The removals are recorded against the 1.7.4 baseline in CompatibilitySuppressions.xml, and the public API baseline drops them.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
This PR is included in version 1.7.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.