Repository navigation
Upgraded to Vite 8 - #29152
Upgraded to Vite 8#29152
Conversation
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 11m 1s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | <1s | View ↗ |
nx run-many -t test:unit -p @tryghost/activityp... |
✅ Succeeded | 7m 42s | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 4s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 37s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 3m 22s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 2m 46s | View ↗ |
nx run-many -t lint -p @tryghost/activitypub,@t... |
✅ Succeeded | 2m 55s | View ↗ |
Additional runs (7) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-07 16:44:25 UTC
WalkthroughThe workspace catalog updates Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pnpm-workspace.yaml`:
- Line 126: The public UMD app builds are still inheriting Vite 8’s default
build target instead of the project support matrix. Update the Vite config used
by the UMD apps to set an explicit build.target, and verify any CJS default
imports still work under Vite 8’s stricter interop. Use the relevant Vite config
entrypoints for the public apps, not browserslist, so the target is enforced
during bundling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f410a4a6-da5c-4b15-9f8e-41e4b7c64b25
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (14)
apps/activitypub/package.jsonapps/admin-x-design-system/package.jsonapps/admin-x-framework/package.jsonapps/admin-x-settings/package.jsonapps/admin/package.jsonapps/announcement-bar/package.jsonapps/comments-ui/package.jsonapps/portal/package.jsonapps/posts/package.jsonapps/shade/package.jsonapps/signup-form/package.jsonapps/sodo-search/package.jsonapps/stats/package.jsonpnpm-workspace.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29152 +/- ##
==========================================
+ Coverage 74.26% 74.31% +0.04%
==========================================
Files 1566 1566
Lines 135737 135737
Branches 16448 16465 +17
==========================================
+ Hits 100806 100869 +63
+ Misses 33901 33865 -36
+ Partials 1030 1003 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ref https://linear.app/ghost/issue/PLA-96 - bumps the catalog `vite` to 8.1.3 and removes the named `rolldown` catalog; all 13 Vite-built apps go back to plain `catalog:`. Vite 8 ships Rolldown as its default bundler, so the transitional rolldown-vite fork is no longer needed - bumps @vitejs/plugin-react 5.2.0 -> 6.0.3 (Oxc-based, Babel-free) and swaps apps/admin from @vitejs/plugin-react-swc onto @vitejs/plugin-react, dropping the swc plugin. Under Vite 8, plugin-react uses the Oxc Fast Refresh transform, so admin keeps fast HMR and the whole repo runs one react plugin - verified: all apps build under Vite 8; react/react-dom stay external in the admin bundles; public UMD apps have 0 require/module leaks and byte-parity sizes; comments-ui 252 unit tests pass
12aaeb5 to
167af8f
Compare
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |

ref PLA-96
Moves every Vite-built app to Vite 8, which ships Rolldown (with Oxc + Lightning CSS) as its default bundler. The apps were already building with Rolldown via the transitional
rolldown-vite@7.3.1fork; Vite 8 makes that native, so the fork is no longer needed.Changes
pnpm-workspace.yaml: bump the catalogvite7.3.2→8.1.3and delete the namedrolldowncatalog."vite": "catalog:rolldown"→"vite": "catalog:"(admin, admin-x-framework, admin-x-settings, admin-x-design-system, shade, posts, stats, activitypub, portal, comments-ui, sodo-search, signup-form, announcement-bar).@vitejs/plugin-react5.2.0→6.0.3(Oxc-based, Babel-free) and swapapps/adminoff@vitejs/plugin-react-swconto@vitejs/plugin-react, removing the swc plugin entirely. Under Vite 8,@vitejs/plugin-reactuses the Oxc Fast Refresh transform (@vitejs/plugin-react-oxcis deprecated in its favor), so admin keeps a Rust-fast HMR path and the whole repo runs a single React plugin.vite@8.1.3is pinned deliberately (≥ 8.0.16, past the advisory range in earlier 8.0.x).Verification
react/react-domstay external in the admin ES bundles (posts, stats, admin-x-settings) — the custom external-globals plugin still resolves them to theReact/ReactDOMglobals; no React inlined.require(/module.exports/import.meta.glob; bundle sizes unchanged (portal 2360 KB, comments-ui 828 KB, sodo-search 264 KB, signup-form 252 KB, announcement-bar 132 KB).Plugin compatibility
@vitejs/plugin-react@6.0.3peersvite: ^8.0.0and ships no Babel (Oxc only); everyreact()call site is bare (no Babel options), so nothing hits v6's dropped-Babel-options break.vitest@4.1.9,vite-plugin-svgr@4.5.0,vite-plugin-css-injected-by-js@3.5.2,@tailwindcss/vite@4.2.2, and@storybook/react-vite@10.4.6all already declare^8in their Vite peer ranges — no further bumps required.