Fix structured from_xarray n_face mapping (#1410) - #1569
Merged
Conversation
Grid.from_structured(lon=, lat=) recorded no source-dim mapping and used a lowercase "structured" spec, so UxDataset.from_xarray could not flatten (lon, lat) data variables onto n_face, leaving them unmapped and breaking subsetting. Capture the lon/lat dim names, use the canonical "Structured" spec, and honor a passed source_dims_dict in from_dataset. Closes #1410.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ASV BenchmarkingBenchmark Comparison ResultsBenchmarks that have improved:
Benchmarks that have stayed the same:
Benchmarks that have got worse:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1410 and the three bugs behind it:
from_structured(lon=, lat=)used lowercase"structured", so the structured-flatten branch never ran.source_dims_dict=None, so(lon, lat) → n_facewas never recorded.from_datasethard-codedsource_dims_dict = {}, dropping any passed mapping.