Skip to content

Clarify in docs: UXarray supports only spherical 2D grids with convex faces - #1626

Merged
rajeeja merged 7 commits into
mainfrom
clarify_docs-spherical_2D_convex
Jul 29, 2026
Merged

Clarify in docs: UXarray supports only spherical 2D grids with convex faces#1626
rajeeja merged 7 commits into
mainfrom
clarify_docs-spherical_2D_convex

Conversation

@Sevans711

Copy link
Copy Markdown
Collaborator

Closes #1597
Closes #1615

Overview

Clarifies in readthedocs pages: UXarray supports only spherical 2D grids with convex faces.

As per discussion in issue 1615:

  • (1) Adds the question, "What does UXarray assume about grids?" and its answer to the FAQs page
  • (2) Adds the new section, "Additional Assumptions of UXarray" on the grid-formats page

As per discussion in issue 1597:

  • Adds .. note:: clarifying these assumptions in the "Why UXarray?" overview page.
  • Clarifies "spherical" assumption.

Labeling this PR with "bug" in addition to "documentation", as in 1615, because uxarray currently silently handles non-convex cases incorrectly.

This PR does not update the UXarray README as originally proposed, because these details might be too specific to include in the README itself. But it should still solve the fundamental problem of lack of clarity in the docs regarding these assumptions, so it should be safe to close the underlying issues when this PR merges.

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Documentation

  • [N/A] Docstrings have been added to all new functions
  • [N/A] Docstrings have updated with any function changes
  • [N/A] Internal functions have a preceding underscore (_) and have been added to docs/internal_api/index.rst
  • [N/A] User functions have been added to docs/user_api/index.rst

@Sevans711 Sevans711 added bug Something isn't working documentation Improvements or additions to documentation labels Jul 27, 2026
@erogluorhan erogluorhan removed the bug Something isn't working label Jul 27, 2026
@erogluorhan

Copy link
Copy Markdown
Member

Labeling this PR with "bug" in addition to "documentation", as in 1615, because uxarray currently silently handles non-convex cases incorrectly.

Since the PR does only documentation type of work, removed the bug label to avoid any confusions.

@erogluorhan erogluorhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this work! Please find a few inline comments below

Comment thread docs/getting-started/freq-asked-questions.rst Outdated
Comment thread docs/getting-started/freq-asked-questions.rst Outdated
Comment thread docs/getting-started/freq-asked-questions.rst Outdated
Comment thread docs/getting-started/freq-asked-questions.rst Outdated
Comment thread docs/getting-started/freq-asked-questions.rst Outdated
Comment thread docs/getting-started/overview.rst Outdated
Comment thread docs/user-guide/grid-formats.rst Outdated
@Sevans711

Copy link
Copy Markdown
Collaborator Author

Thank you for your review and suggestions @erogluorhan! I believe I have incorporated them all, though with some rephrasing on my part. If I mangled anything during the rephrasing please let me know. Small notes:

  • The .. note:: in the "Why UXarray?" page remains less detailed than the FAQ because many of the details already exist directly above it in the Why UXarray page.
  • I didn't add coordinates details in the additions to the grid-formats.rst file in this PR because coordinates details are discussed in the subsequent section in that file already.
  • The broken link I added ("Supported Models & Grid Formats") in the FAQ has been fixed, I double-checked that it seems to be working now!

@Sevans711
Sevans711 requested a review from erogluorhan July 28, 2026 14:18

@erogluorhan erogluorhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Please find a few new comments below

Comment thread docs/getting-started/freq-asked-questions.rst Outdated
Comment thread docs/getting-started/overview.rst Outdated
Comment thread docs/getting-started/overview.rst Outdated
Comment thread docs/getting-started/overview.rst Outdated

.. note::
While 3D grids with vertical levels are supported, fully 3D unstructured topology is not.
Also, UXarray additionally assumes the horizontal portion of the grid lies on a spherical surface,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just say "... assumes the grid lies..."

Comment thread docs/user-guide/grid-formats.rst Outdated
Updates in response to PR review 2 (see #1626)
@Sevans711

Sevans711 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Thank you for taking another close look at this, @erogluorhan. I believe 6804e79 addresses most of your comments, aside from the notes below, but please let me know if you have suggestions for more revisions!

Small notes:

  • I did add links in the overview.rst file as requested, but I did not add links in the grid-formats.rst file yet (for "UGRID conventions' 2D flexible mesh topology" and "UGRID conventions' 3D layered mesh topology"). I figured it may make sense to avoid putting too many links there in grid-formats.rst. The UGRID conventions doc is already linked above, and more UGRID references are already linked below. But, I don't feel strongly about it; if you prefer links here too just let me know and I would be happy to add them.
  • I did not yet remove the "the horizontal portion of the grid…" phrasing; see comment above. I think this point will lead to making some small clarifying changes one way or another, but it may make more sense to hash out those details here before making the changes directly. EDIT: woops, I see your comments now, I guess github was slow to load them or I forgot to refresh the page before I made these changes. Your clarifications sound good. I will push a new commit soon.

Comment thread docs/user-guide/grid-formats.rst Outdated
Comment thread docs/user-guide/grid-formats.rst Outdated
Comment thread docs/user-guide/grid-formats.rst Outdated
@Sevans711
Sevans711 requested a review from erogluorhan July 28, 2026 18:04
@Sevans711

Copy link
Copy Markdown
Collaborator Author

I believe I've implemented all your suggestions now, and re-requested review. I will take a pause from looking at this for a little while, to avoid duplicating any work / in case my commits have been interrupting your reviews. I appreciate the quick feedback on all of this!

Comment thread docs/user-guide/grid-formats.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is

rx`earch

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look! I believe this was meant to be "research". I also noticed a few other minor typos in the nearby text in this section and fixed those as well.

@@ -39,17 +40,29 @@ The standard was developed over a period of several years through the UGRID Goog
different unstructured grid modeling communities (including SELFE, ELCIRC, FVCOM, ADCIRC). From these discussions Bert
Jagers (Deltares) created the first draft of this document, and the community worked to develop version 1.0.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add that UGRID was officially included in CF.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@erogluorhan erogluorhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks for taking this on and all the review iterations!

@rajeeja
rajeeja merged commit 852a0c0 into main Jul 29, 2026
13 checks passed
@Sevans711
Sevans711 deleted the clarify_docs-spherical_2D_convex branch July 29, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UXarray docs (& readme?) should clarify "assuming convex faces" UXarray readme & docs should quickly clarify "spherical, 2D"

4 participants