Clarify in docs: UXarray supports only spherical 2D grids with convex faces - #1626
Conversation
Since the PR does only documentation type of work, removed the bug label to avoid any confusions. |
erogluorhan
left a comment
There was a problem hiding this comment.
Thanks a lot for this work! Please find a few inline comments below
Updates in response to PR review (see #1626)
|
Thank you for your review and suggestions @erogluorhan! I believe I have incorporated them all, though with some rephrasing on my part. If I mangled anything during the rephrasing please let me know. Small notes:
|
erogluorhan
left a comment
There was a problem hiding this comment.
Almost there! Please find a few new comments below
|
|
||
| .. note:: | ||
| While 3D grids with vertical levels are supported, fully 3D unstructured topology is not. | ||
| Also, UXarray additionally assumes the horizontal portion of the grid lies on a spherical surface, |
There was a problem hiding this comment.
just say "... assumes the grid lies..."
Updates in response to PR review 2 (see #1626)
|
Thank you for taking another close look at this, @erogluorhan. I believe 6804e79 addresses most of your comments, aside from the notes below, but please let me know if you have suggestions for more revisions! Small notes:
|
as per review comments on #1626
|
I believe I've implemented all your suggestions now, and re-requested review. I will take a pause from looking at this for a little while, to avoid duplicating any work / in case my commits have been interrupting your reviews. I appreciate the quick feedback on all of this! |
There was a problem hiding this comment.
Thank you for taking a look! I believe this was meant to be "research". I also noticed a few other minor typos in the nearby text in this section and fixed those as well.
| @@ -39,17 +40,29 @@ The standard was developed over a period of several years through the UGRID Goog | |||
| different unstructured grid modeling communities (including SELFE, ELCIRC, FVCOM, ADCIRC). From these discussions Bert | |||
| Jagers (Deltares) created the first draft of this document, and the community worked to develop version 1.0. | |||
There was a problem hiding this comment.
Should add that UGRID was officially included in CF.
erogluorhan
left a comment
There was a problem hiding this comment.
Looks great; thanks for taking this on and all the review iterations!
Closes #1597
Closes #1615
Overview
Clarifies in readthedocs pages: UXarray supports only spherical 2D grids with convex faces.
As per discussion in issue 1615:
As per discussion in issue 1597:
.. note::clarifying these assumptions in the "Why UXarray?" overview page.Labeling this PR with "bug" in addition to "documentation", as in 1615, because uxarray currently silently handles non-convex cases incorrectly.
This PR does not update the UXarray README as originally proposed, because these details might be too specific to include in the README itself. But it should still solve the fundamental problem of lack of clarity in the docs regarding these assumptions, so it should be safe to close the underlying issues when this PR merges.
PR Checklist
General
Documentation
_) and have been added todocs/internal_api/index.rstdocs/user_api/index.rst