Improve memory usage when computing the true bounding box#25
Merged
Conversation
A potentially large amount of memory was being consumed by the list of HorizontalPosition objects in pursuit of computing the true grid bounding box. This change skips constructing the list saving memory. This change also caches the bounding box, as multiple grids may share the same set of horizontal axes, which can save quite a lot of time for high resolution datasets with a large number of grids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A potentially large amount of memory was being consumed by the list of HorizontalPosition objects in pursuit of computing the true grid bounding box. This change skips constructing the list saving memory. This change also caches the bounding box, as multiple grids may share the same set of horizontal axes, which can save quite a lot of time for high resolution datasets with a large number of grids.