Skip to content

Bump jsviews from 1.0.15 to 1.2.0 - #1818

Closed
dependabot[bot] wants to merge 1 commit into
devfrom
dependabot/npm_and_yarn/dev/jsviews-1.2.0
Closed

dependabot[bot] wants to merge 1 commit into
devfrom
dependabot/npm_and_yarn/dev/jsviews-1.2.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Bumps jsviews from 1.0.15 to 1.2.0.

Release notes

Sourced from jsviews's releases.

v1.2.0 (jQuery 4 compatibility)

JsViews v1.2.0 (jQuery 4 compatibility)

v1.0.16

JsViews v1.0.16

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [jsviews](https://github.com/borismoore/jsviews) from 1.0.15 to 1.2.0.
- [Release notes](https://github.com/borismoore/jsviews/releases)
- [Commits](BorisMoore/jsviews@v1.0.15...v1.2.0)

---
updated-dependencies:
- dependency-name: jsviews
  dependency-version: 1.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 13, 2026
@vercel

vercel Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
universalviewer Ready Ready Preview, Comment Jul 13, 2026 12:53am
universalviewer.dev Ready Ready Preview, Comment Jul 13, 2026 12:53am

Request Review

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, this is breaking the index tab of the left content sidebar. We'll have to figure out why (and see if the issue affects other parts of the code) before it can be merged.

@LanieOkorodudu

Copy link
Copy Markdown
Contributor

I also noticed the following console error when opening the Index tab: Cannot read properties of undefined (reading 'getAllNodes') I'm not sure whether this error is causing the issue or is a consequence of the tree not being rendered.

@LanieOkorodudu

Copy link
Copy Markdown
Contributor

@demiankatz, I had a look into why this update is breaking the Index tab. It looks like jsviews@1.2.0 requires jquery ^3.7.1, while UV is currently using jquery 3.5.0. This results in two different versions of jQuery being installed, and the Index tree fails with $.templates is not a function.
I also tested this against the latest dev branch and could reproduce the same issue. I then updated jQuery to 3.7.1 alongside jsviews 1.2.0 on my local branch, and the Index tree is working again. The tests are also running successfully.
If you're happy with this approach, I can push the changes to address this PR.

@demiankatz

Copy link
Copy Markdown
Contributor

Thanks, @LanieOkorodudu, that makes sense!

Another option would be to finish up #1738, which will get us all the way to jQuery 4. (It's still on my to-do list to review the jQuery 4 changelog so I can get a sense of potential risk areas... just haven't found time yet).

Given that jQuery 4 is taking me a while, I think that your proposal that we upgrade to the latest jQuery 3 here in the meantime seems like the most practical path forward!

@LanieOkorodudu

Copy link
Copy Markdown
Contributor

Thanks, @LanieOkorodudu, that makes sense!

Another option would be to finish up #1738, which will get us all the way to jQuery 4. (It's still on my to-do list to review the jQuery 4 changelog so I can get a sense of potential risk areas... just haven't found time yet).

Given that jQuery 4 is taking me a while, I think that your proposal that we upgrade to the latest jQuery 3 here in the meantime seems like the most practical path forward!

Yes, I agree. Upgrading to jQuery 3.7.1 for the meantime makes sense, and hopefully the jQuery 4 work will give us a more solid long-term solution. I’ll go ahead and push the changes.

@demiankatz

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot @github

dependabot Bot commented on behalf of github Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Looks like jsviews is up-to-date now, so this is no longer needed.

@dependabot dependabot Bot closed this Sep 29, 2026
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/dev/jsviews-1.2.0 branch September 29, 2026 12:07

This branch was successfully deployed

2 active deployments
Preview – universalviewer.dev β€” ebfa1e61 Deployed Jul 13, 2026 by vercel[bot]
Preview – universalviewer β€” ebfa1e61 Deployed Jul 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

2 participants