Make nullability optional

[bastianeicher]

I'd like to suggest making the nullability of the generated properties optional. I think for most use-cases it can be safely assumed the resources will always return a value (falling back to the neutral language if the thread's current language is not available).

As it is currently, I'd need to litter my code with lot's of ! everywhere I access Resources (e.g. string.Format(Resources.MyResource!, someVar) instead of string.Format(Resources.MyResource, someVar).

[ycanardeau]

I also think for most use-cases it can be safely assumed the resources will always return a value, but what would be the best way? I came up with the following ideas.

1. Use the null-forgiving operator.

public static string CreateDate => ResourceManager.GetString(nameof(CreateDate), CultureInfo)!;

2. Return an empty string.

public static string CreateDate => ResourceManager.GetString(nameof(CreateDate), CultureInfo) ?? string.Empty;

3. Throw an exception.

public static string CreateDate => ResourceManager.GetString(nameof(CreateDate), CultureInfo) ?? throw new InvalidOperationException();

As a workaround, you can use v1.0.2 instead of v1.0.3, because the former generates code just like option 1.

[bastianeicher]

Personally, I'd go with Option 1 because:
Option 2 hides a problem in the unlikely case there is one.
Option 3 adds a (tiny) extra overhead because each resource access performs an additional if-check.

Thanks for the hint with v1.0.2! :)

[ycanardeau]

I took option 1 and published v1.0.4. Now that I replaced SyntaxFactory with StringBuilder, it should be a little bit faster. Thanks for your feedback! :)