Repository navigation
style(vaults): prune narrative comments from the join-links work - #227
Merged
Merged
Conversation
The #226 code narrated itself: block headers restating what the next lines do, multi-line rationale that belongs in the commit message, and JSDoc on obvious test helpers. It also matched the dense commenting of the surrounding vault-share files, which is not the house style to copy. What stays is the load-bearing kind only, one or two lines each: why the key-holder check happens in the button path rather than in distributeKeyToNewMember, why the expiry unit floors but the count rounds, why vaultId can be a team id, why fetchAuthRateLimited is not folded into fetchAuthJson, and that a link carries membership and never the vault key. No behaviour change; 1381 tests across the touched suites pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014gY5k7XbeR5zoTXdzsuWxF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #226. That code narrated itself — block headers restating what the next lines do, multi-line rationale that belongs in the commit message, and JSDoc on obvious test helpers. It also matched the dense commenting of the surrounding
vault-sharefiles, which is not the style to copy.243 comment lines out, 54 in (most of those the shortened replacements). No behaviour change.
What stays is the load-bearing kind only, one or two lines each:
distributeKeyToNewMembervaultIdcan be a team idfetchAuthRateLimitedis not folded intofetchAuthJsonaccount_id/ KDF-salt constraint on the deep-link codectscclean; 1381 tests acrossvault-share,terminal,layout,membersandservicespass.🤖 Generated with Claude Code
https://claude.ai/code/session_014gY5k7XbeR5zoTXdzsuWxF