Skip to content

fix(ux): improve History revert/details button spacing - #21573

Merged
nijel merged 4 commits into
WeblateOrg:mainfrom
diptomistry:fix-8259-revert-button-spacing
Sep 10, 2026
Merged

nijel merged 4 commits into
WeblateOrg:mainfrom
diptomistry:fix-8259-revert-button-spacing

Conversation

@diptomistry

@diptomistry diptomistry commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Scope History .btn-float actions to #changes-table: 10px gap, per-button border/padding, hover/focus background.
  • Changelog entry under Weblate 2026.10 Improvements.
    Fixes Revert buttons are unclear #8259

Test plan

  • Open project History / changes browse: Revert and View details are spaced and separately bordered
  • Open per-string History tab: same button treatment
  • Keyboard focus shows background change on the action buttons
  • Suggestions/comments .btn-float outside History unchanged

Screenshots

before:

before-btn-float-crop

after:
after-btn-float-crop

Widen gap and give each History action its own bordered control
with clearer hover/focus so Revert is harder to hit by mistake.

Fixes WeblateOrg#8259
@nijel
nijel requested a review from KarenKonou September 10, 2026 08:52
@nijel

nijel commented Sep 10, 2026

Copy link
Copy Markdown
Member

#8259 also brought another question: the clarity of these icons, so while this might improve the situation, I'm not sure if it fully addresses the concerns brought there.

@diptomistry

diptomistry commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor Author

Agreed — this addresses the spacing/misclick part of the issue (solution 3, per your original guidance), but icon clarity is a separate, larger question. Happy to leave that as a follow-up issue if it's worth tracking separately, rather than expanding this PR's scope.

@KarenKonou KarenKonou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is fine in terms of making the buttons more visible, if we want to increase their size we can easily do that at any point.

Comment thread weblate/static/styles/main.css Resolved
Co-authored-by: KarenKonou <37159053+KarenKonou@users.noreply.github.com>
@diptomistry

Copy link
Copy Markdown
Contributor Author

Good catch, applied — thanks!

@nijel nijel self-assigned this Sep 10, 2026
@nijel nijel added this to the 2026.10 milestone Sep 10, 2026
@nijel
nijel merged commit fb9040c into WeblateOrg:main Sep 10, 2026
35 checks passed
@nijel

nijel commented Sep 10, 2026

Copy link
Copy Markdown
Member

Merged, thanks for your contribution!

@diptomistry
diptomistry deleted the fix-8259-revert-button-spacing branch September 10, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert buttons are unclear

3 participants