Skip to content

Script Loader: Enable wp_script_attributes filter in _print_scripts() #11702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sukhendu2002 wants to merge 8 commits into from
Closed

Script Loader: Enable wp_script_attributes filter in _print_scripts() #11702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fab6a5a
Script Loader: Use wp_print_script_tag() and wp_print_inline_script_t…
Sukhendu2002 May 4, 2026
049a883
Merge branch 'trunk' into fix/64683-print-scripts-filters
Sukhendu2002 May 7, 2026
02dff13
Script Loader: Simplify inline script tag output by inlining the conc…
Sukhendu2002 May 7, 2026
828f7f2
Merge branch 'trunk' into fix/64683-print-scripts-filters
t-hamano Jul 10, 2026
fdab937
Merge branch 'trunk' into fix/64683-print-scripts-filters
westonruter Jul 14, 2026
644e5a1
Add missing global doc tags
westonruter Jul 14, 2026
da158cc
Indent heredoc now that PHP 7.4 is minimum version
westonruter Jul 14, 2026
3835f31
Add remaining missing global tag
westonruter Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/wp-includes/script-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2230,10 +2230,7 @@ function _print_scripts() {

if ( $concat ) {
if ( ! empty( $wp_scripts->print_code ) ) {
echo "\n<script>\n";
echo $wp_scripts->print_code;
echo sprintf( "\n//# sourceURL=%s\n", rawurlencode( 'js-inline-concat-' . $concat ) );
echo "</script>\n";
wp_print_inline_script_tag( $wp_scripts->print_code . "\n//# sourceURL=" . rawurlencode( 'js-inline-concat-' . $concat ) );
}

$concat = str_split( $concat, 128 );
Expand All @@ -2244,7 +2241,7 @@ function _print_scripts() {
}

$src = $wp_scripts->base_url . "/wp-admin/load-scripts.php?c={$zip}" . $concatenated . '&ver=' . $wp_scripts->default_version;
echo "<script src='" . esc_attr( $src ) . "'></script>\n";
wp_print_script_tag( array( 'src' => $src ) );
}

if ( ! empty( $wp_scripts->print_html ) ) {
Expand Down
24 changes: 15 additions & 9 deletions tests/phpunit/tests/dependencies/scripts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2275,6 +2275,9 @@ public function test_protocols() {

/**
* Test script concatenation.
*
* @global WP_Scripts $wp_scripts
* @global string $wp_version
*/
public function test_script_concatenation() {
global $wp_scripts, $wp_version;
Expand All @@ -2289,9 +2292,9 @@ public function test_script_concatenation() {
wp_print_scripts();
$print_scripts = get_echo( '_print_scripts' );

$expected = "<script src='/wp-admin/load-scripts.php?c=0&amp;load%5Bchunk_0%5D=one,two,three&amp;ver={$wp_version}'></script>\n";
$expected = "<script src=\"/wp-admin/load-scripts.php?c=0&#038;load%5Bchunk_0%5D=one,two,three&#038;ver={$wp_version}\"></script>\n";

$this->assertSame( $expected, $print_scripts );
$this->assertEqualHTML( $expected, $print_scripts );
}

/**
Expand Down Expand Up @@ -4310,6 +4313,10 @@ public function test_source_url_encoding() {

/**
* @ticket 63887
*
* @global WP_Scripts $wp_scripts
* @global bool $concatenate_scripts
* @global string $wp_version
*/
public function test_source_url_with_concat() {
global $wp_scripts, $concatenate_scripts, $wp_version;
Expand All @@ -4328,14 +4335,13 @@ public function test_source_url_with_concat() {
$print_scripts = get_echo( '_print_scripts' );

$expected = <<<HTML
<script>
var one = {"key":"val"};var two = {"key":"val"};
//# sourceURL=js-inline-concat-one%2Ctwo
</script>
<script src="/wp-admin/load-scripts.php?c=0&#038;load%5Bchunk_0%5D=one,two&#038;ver={$wp_version}"></script>

<script>
var one = {"key":"val"};var two = {"key":"val"};
//# sourceURL=js-inline-concat-one%2Ctwo
</script>
<script src="/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=one,two&ver={$wp_version}"></script>

HTML;
HTML;

$this->assertEqualHTML( $expected, $print_scripts );
}
Expand Down
Loading