Add textShadow typography support and UI - #12011
Conversation
Allow the `text-shadow` CSS property to be defined under `styles.typography` in theme.json, so text shadows can be set globally or at the block and element level. Registers the property in `WP_Theme_JSON::PROPERTIES_METADATA` and `VALID_STYLES`, with coverage added to the `get_stylesheet()` test. This ports the PHP changes from the Gutenberg feature to core. See #61256. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@ramonjd, @aaronrobertshaw, WordPress/gutenberg#79584 will likely be deferred to 7.2. This means that the UI for text shadow will not be exposed in 7.1, and only the styles will be supported. I believe this PR is ready for commit, and I await your review 🙇♂️ |
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Backport looks good.
Just to confirm: only theme.json global styles work, and only on the frontend
| Editor | Frontend |
|---|---|
 |
 |
|
@ramonjd Thanks for the review!
This is correct. The text shadow should work in the editor once the latest Gutenberg is synced to core. |
Adds `typography.textShadow` to `WP_Theme_JSON` so a `text-shadow` value defined in theme.json global styles is rendered as a `text-shadow` CSS declaration. Developed in: #12011 Props ramonopoly, wildworks. Fixes #65370. git-svn-id: https://develop.svn.wordpress.org/trunk@62728 602fd350-edb4-49c9-b593-d223f7449a82
Adds `typography.textShadow` to `WP_Theme_JSON` so a `text-shadow` value defined in theme.json global styles is rendered as a `text-shadow` CSS declaration. Developed in: WordPress/wordpress-develop#12011 Props ramonopoly, wildworks. Fixes #65370. Built from https://develop.svn.wordpress.org/trunk@62728 git-svn-id: http://core.svn.wordpress.org/trunk@62012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2 participants
This PR is intended to backport the following Gutenberg PRs to the core in order to implement full text shadow support in a single PR.
Add textShadow typography support and UI gutenberg#79584Trac ticket: https://core.trac.wordpress.org/ticket/65370
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.