Skip to content

Toolbar: Show the item indicator on hover as well as on focus. - #12969

Open
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:65849-toolbar-hover-indicator
Open

Toolbar: Show the item indicator on hover as well as on focus.#12969
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:65849-toolbar-hover-indicator

Conversation

@t-hamano

@t-hamano t-hamano commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

A visual indicator now appears when elements in the admin bar are focused, thanks to r63009. However, this results in a similar bar appearing when clicking with the mouse, which feels slightly unnatural.

I came up with two approaches:

  • Use focus-visible to display the indicator only when an element is focused via keyboard.
  • Display the indicator not only on focus but also on hover.

I chose the latter approach for consistency with the sidebar.

Trac ticket: https://core.trac.wordpress.org/ticket/65849

theme-dafault.mp4
theme-sunrise.mp4

Use of AI Tools

Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.

After [63009] the toolbar items indicator was only shown on focus, which made
it look like a leftover focus style after clicking a menu item with a pointer.

Show the same indicator on hover for link related toolbar items, both at the
top level and within submenus, so the pointer interaction matches the keyboard
one.

See #65849.

Co-Authored-By: Claude <noreply@anthropic.com>
@t-hamano
t-hamano marked this pull request as ready for review August 11, 2026 15:02
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@afercia afercia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants