Toolbar: Show the item indicator on hover as well as on focus. - #12969
Toolbar: Show the item indicator on hover as well as on focus.#12969t-hamano wants to merge 1 commit into
Conversation
After [63009] the toolbar items indicator was only shown on focus, which made it look like a leftover focus style after clicking a menu item with a pointer. Show the same indicator on hover for link related toolbar items, both at the top level and within submenus, so the pointer interaction matches the keyboard one. See #65849. Co-Authored-By: Claude <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
A visual indicator now appears when elements in the admin bar are focused, thanks to r63009. However, this results in a similar bar appearing when clicking with the mouse, which feels slightly unnatural.
I came up with two approaches:
I chose the latter approach for consistency with the sidebar.
Trac ticket: https://core.trac.wordpress.org/ticket/65849
theme-dafault.mp4
theme-sunrise.mp4
Use of AI Tools
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.