Upgrading WPCS

[pento]

Running Travis tests.

[jrfnl]

@pento Is the exclude pattern the problem ? If so, what were you trying to exclude specifically there ? Is there a way to make the pattern more specific to get round the issue ? Exclude patterns are basically regular expressions, with just the one extra that * will be automatically converted to the regex .* pattern.

[pento]

Yeah, the problem is that our phpcs.xml.dist has the rule <exclude-pattern>/build/*</exclude-pattern>. Travis puts everything in the /home/travis/build/WordPress/wordpress-develop folder. Per squizlabs/PHP_CodeSniffer#981, this behaviour is unlikely to change, so the workaround is to change the folder on Travis.

[jrfnl]

the problem is that our phpcs.xml.dist has the rule /build/*

But what is that rule trying to exclude ? If I understand that, then I can help you devise a better exclude-pattern which prevents the problem from occurring in the first place.

Something like the below might already be enough to fix this:

<exclude-pattern>(?<!/travis)/build/*</exclude-pattern>

[pento]

It's to exclude the build directory that's created when you run grunt build: no point in checking code that's just copied from the src directory.

[jrfnl]

@pento In that case, the regex exclude pattern I posted above should do the trick.

[jrfnl]

@pento Cricky.. just thinking the < in the look behind might not be accepted in XML. You could try passing it as:

<exclude-pattern>(?&lt;!/travis)/build/*</exclude-pattern>

... and see if that works. If not, I'll come up with a different regex.

[pento]

Yup, that worked. 🙂

[jrfnl]

@pento Just thinking - we could probably make it even simpler (and more easily understandable for others), by using

<exclude-pattern type="relative">^build/*</exclude-pattern>

The relative in this case, means relative to where the ruleset is placed (not relative to basepath which is only used for trimming the filepaths down).

I would give you a link to the PHPCS wiki which explains this feature, however, that page is (temporarily) inaccessible.

[pento]

Okay, I'm happy with the state of this. I'm going to merge it into Core later today, we can work on getting the custom bits into WPCS 1.1, and then we can easily upgrade Core again.