HTML API: Add support for group of containers including ARTICLE element - #5538
Closed
dmsnell wants to merge 1 commit into
Closed
Conversation
dmsnell
force-pushed
the
html-api/add-support-for-remaining-address-article-group
branch
from
November 15, 2023 19:38
7fc51fe to
7f703c3
Compare
dmsnell
marked this pull request as ready for review
November 15, 2023 19:38
dmsnell
force-pushed
the
html-api/add-support-for-remaining-address-article-group
branch
from
November 15, 2023 20:58
7f703c3 to
d0b8f37
Compare
ockham
reviewed
Nov 16, 2023
ockham
reviewed
Nov 16, 2023
dmsnell
force-pushed
the
html-api/add-support-for-remaining-address-article-group
branch
from
November 16, 2023 15:38
d0b8f37 to
6e25b34
Compare
There are a handful of elements the behave similarly and are generically
container elements. These are the following elements:
ADDRESS, ARTICLE, ASIDE, BLOCKQUOTE, CENTER, DETAILS, DIALOG, DIR,
DL, DIV, FIELDSET, FIGCAPTION, FIGURE, FOOTER, HEADER, HGROUP, MAIN,
MENU, NAV, SEARCH, SECTION, SUMMARY,
This patch adds support to the HTML Processor for handling these elements.
They do not require any additional logic in the rest of the class, and carry
no specific semantic rules for parsing beyond what is listed in their group
in the IN BODY section of the HTML5 specification.
Co-authored-by: Bernie Reiter <bernhard-reiter@git.wordpress.org>
dmsnell
force-pushed
the
html-api/add-support-for-remaining-address-article-group
branch
from
November 16, 2023 15:43
6e25b34 to
0dc859f
Compare
ockham
approved these changes
Nov 16, 2023
ockham
left a comment
ockham
left a comment
Contributor
There was a problem hiding this comment.
Thank you for addressing my feedback! I'm wrapping up work for tonight, but I'm planning to land this tomorrow 😄
LGTM 🚢
Contributor
|
BTW really appreciate the test coverage -- they're easy to read and follow, and provide a lot of confidence in the code changes! 🙌 |
Contributor
|
Committed to Core in https://core.trac.wordpress.org/changeset/57115. |
dmsnell
deleted the
html-api/add-support-for-remaining-address-article-group
branch
November 17, 2023 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-59914
There are a handful of elements the behave similarly and are generically
container elements. These are the following elements:
This patch adds support to the HTML Processor for handling these elements.
They do not require any additional logic in the rest of the class, and carry
no specific semantic rules for parsing beyond what is listed in their group
in the IN BODY section of the HTML5 specification