-
Notifications
You must be signed in to change notification settings - Fork 3.6k
HTML API: Update customizable <select> parsing #9298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
sirreal
wants to merge
40
commits into
WordPress:trunk
from
sirreal:html-api/update-select-tag-parsing
Closed
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
aaee111
Apply patch from <select> parser PR
sirreal 9ab745d
Update reset_insertion_mode_appropriately
sirreal 1acfce7
Deprecate the has_element_in_select_scope method
sirreal aac853d
Update "normal" end tag handling to include SELECT
sirreal 89c113d
Update INPUT handling to account for SELECT
sirreal f75a08f
Update HR tag handling
sirreal 099f013
Update SELECT insertion handling
sirreal 7fe3598
Update OPTION, OPTGROUP insertion handling
sirreal 20e0807
Remove in_select and in_select_in_table step methods
sirreal 45edeae
Deprecate unused insertion mode constants
sirreal 446cdaa
Adjust html5lib-test expectation
sirreal 0ed0a68
Add close option tag comments, do not handle cloning
sirreal 8beb128
Update has_element_in_scope with SELECT
sirreal 6be6287
Bail when parsing SELECTEDCONTENT requiring clone
sirreal 9e79bb2
Update html5lib-tests
sirreal e53ed75
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal 95c0559
Update html5lib-tests from 9fb614afaa42ce8787840f057b32084308e76549
sirreal 171c24f
HTML API: Set select deprecation versions to 7.1.0.
sirreal 120619b
HTML API: Empty the deprecated select scope check.
sirreal 8f0bf91
HTML API: Use isset() for context node checks in select handling.
sirreal e9826a6
HTML API: Remove redundant OPTION end tag comment.
sirreal e30d007
HTML API: Document customizable select support in class docs.
sirreal c863814
HTML API: Treat SELECT as a button and list item scope boundary.
sirreal 2f078d0
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal a2d0670
HTML API: Ignore deprecated select parsing internals
sirreal 805cf1f
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal 84428a2
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal b112535
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal 5ceee97
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal b782ba3
HTML API: Stop bailing on selectedcontent
sirreal 73d1976
Replace longer selectedcontent note with unsupported text
sirreal 2c7418a
Remove redundant note
sirreal 7292046
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal c4fdcac
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal 502b6a6
Fix ignored test webkit file name
sirreal 12dd1bd
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal 7ba6401
Merge branch 'trunk' into html-api/update-select-tag-parsing
sirreal 1ccc65f
Remove spec change PR links
sirreal c121db7
Prefer link annotation for external links
sirreal 9ab8c38
Skip unsupported tests for "maybe clone an option into selectedconten…
sirreal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s leave a message that the HTML spec changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's information in the function's
@deprecatedannotation._deprecated_function()doesn't accept arbitrary messages, just the name, deprecating version, and a replacement function (of which there's none).wordpress-develop/src/wp-includes/html-api/class-wp-html-open-elements.php
Line 477 in 12dd1bd