fix(rtt): Down.mode() uses self.flags instead of self.mode#984
Open
by965738071 wants to merge 1 commit into
Open
fix(rtt): Down.mode() uses self.flags instead of self.mode#984by965738071 wants to merge 1 commit into
by965738071 wants to merge 1 commit into
Conversation
by965738071
commented
Jul 17, 2026
Contributor
- Bug: Down.mode() referenced self.mode (the method itself) instead of the flags field, causing a compile error on Zig 0.17
- Fix: changed self.mode to self.flags, matching the Up.mode() pattern
- Add build.zig test step with 5 unit tests covering mode get/set, Writer/Reader compilation, and Up mode verification
- Add test for Down set_mode + mode round-trip
- Bug: Down.mode() referenced self.mode (the method itself) instead of the flags field, causing a compile error on Zig 0.17 - Fix: changed self.mode to self.flags, matching the Up.mode() pattern - Add build.zig test step with 5 unit tests covering mode get/set, Writer/Reader compilation, and Up mode verification - Add test for Down set_mode + mode round-trip
Contributor
|
How did you test this? |
Contributor
Author
|
The
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.