cdc: handle short writes in flush instead of asserting#987
Closed
by965738071 wants to merge 1 commit into
Closed
Conversation
ep_writev can return fewer bytes than requested. The old assert was stripped in release builds, silently dropping data on short writes. Now we keep the unsent tail in the buffer and retry on the next flush.
Contributor
|
How did you test? |
Contributor
|
This needs manual testing and your other answers around this are indicating you're finding easy bugs with an LLM. I'm not going to accept this one without testing, so please open an issue instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ep_writev can return fewer bytes than requested. The old assert was stripped in release builds, silently dropping data on short writes. Now we keep the unsent tail in the buffer and retry on the next flush.