[DX-1381] feat(skills): add Zed as a skills install target#405
[DX-1381] feat(skills): add Zed as a skills install target#405umair-ably wants to merge 1 commit into
Conversation
Zed now ships official support for Agent Skills, loading user-level skills
from ~/.agents/skills/ (per zed.dev/docs/ai/skills). Extend the one-command
onboarding (`ably init`) and `ably skills install` to support Zed:
- Add `zed` to TARGET_CONFIGS (file-copy into ~/.agents/skills/). Both
commands derive their `--target` options from this map, so it propagates
to `ably init` and `ably skills install` automatically.
- Add Zed to the tool detector (CLI `zed`, /Applications/Zed.app on macOS,
~/.local/zed.app + /usr/{bin,lib}/zed on Linux, %LOCALAPPDATA% on Windows,
~/.config/zed config dir) so auto-detect picks it up.
- Cover Zed in tool-detector, skills-installer, and command help tests.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR adds Zed as a supported target for Changes
Review Notes
|
There was a problem hiding this comment.
Review Summary
Clean, well-scoped addition. The implementation follows existing patterns exactly and all test coverage is appropriate.
What the PR does
Adds Zed as a fourth --target option for ably init and ably skills install. Skills are written to ~/.agents/skills/ (Zed's documented user-level path). Detection covers the CLI binary, platform-specific app bundle paths, and the ~/.config/zed config directory.
No issues found
The code is structurally identical to the Windsurf entry that preceded it — same pattern, same test coverage shape:
TARGET_CONFIGSentry with the correctrelativeDirper Zed docsTOOL_CHECKSentry with CLI name, app bundle paths for macOS/Linux, and config dir fallback- Tests for tool detection, multi-target install, and help output all updated consistently
The one thing worth calling out (not a blocker): winPaths is speculative — Zed doesn't have a Windows release as of this writing. That said, the detection logic is platform-gated (win32 only), so on macOS/Linux the path is never evaluated, and on Windows the fs.existsSync check simply returns false. No user-visible impact either way.
Approved — ready to merge.
Overview
Adds Zed as a skills install target, extending the one-command onboarding (
ably init) andably skills installto cover Zed's newly-shipped Agent Skills support.Zed loads user-level Agent Skills from
~/.agents/skills/(verified against zed.dev/docs/ai/skills; project-level lives at<worktree>/.agents/skills/).Changes
skills-installer.ts— addzedtoTARGET_CONFIGS(file-copy into~/.agents/skills/). Bothably initandably skills installderive their--targetoptions from this map, so the new target propagates to both commands automatically.tool-detector.ts— add Zed to the tool detector (CLIzed,/Applications/Zed.appon macOS,~/.local/zed.app+/usr/{bin,lib}/zedon Linux,%LOCALAPPDATA%on Windows,~/.config/zedconfig dir) so auto-detect picks it up.Testing
pnpm testfor the four affected suites: 57/57 passing.🤖 Generated with Claude Code