Normalize a single-pattern paths value in make_test_data.py - #166
Merged
Merged
Conversation
A paths value written as ('glob') with no trailing comma is a string, not a
one-element tuple, so the live-archive search iterated it character by
character. The leading '*' matched every member of the archive, and the
artifact's test data zip took the whole extraction instead of the responsive
files.
process_archive now normalizes a bare string to a one-element tuple, the same
way match_files_from_list and the main loop already do. The pre-compiled
filepath_list branch is unchanged.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test data generation when an artifact's
pathsholds a single pattern written without its trailing comma.('glob')is a string, not a one-element tuple, so the live-archive search inprocess_archiveiterated it one character at a time. The leading*matched every member, and the artifact's test data zip took the whole extraction instead of the responsive files.process_archivenow normalizes a bare string the waymatch_files_from_listand the main loop already do. The pre-compiledfilepath_listbranch is unchanged.No artifact in this repo currently declares
pathsthat way, so this is the matching change rather than a fix for observed output here.