[Okabe-Junya]

What

• Make the e2e workflow read the runner-side Go version from go.mod (toolchain line first, then the go line) instead of a hard-coded string
• Apply the go fix modernizers that are mechanical and self-contained, one family per commit: range-over-int, maps.Copy / slices.Contains, strings.SplitSeq, interface{} → any, reflect.Type.Fields

[nikola-jokic]

Hey @Okabe-Junya , I'm currently bumping all dependencies, just so you know

[Okabe-Junya]

@nikola-jokic

Thank you for sharing and happy to hear that!! If so, I could leave this work to you. Could you handle instead?
What I want to do in this PR are

• Use go toolchain directive instead of go directive to manage go version
• Execute go fix with the latest go version and applied some fixes

WDYT about these? and could you include these in your PRs? (Or I could handle these stuffs instead :) )

[Okabe-Junya]

Hi Nikola, thank you for all your work to release 0.15.0!!
As you mentioned, Go version in master is already 1.27.x, so I dropped go version bump and just keep some minor improvements (suggested by fresh go fix).

Could you have a look when you have time? Thank you!!

[Copilot]

Copilot review overview

🟡 Changes recommended

Kubernetes-container e2e jobs retain a hard-coded Go image version and can drift from go.mod.

Review effort: Balanced
Findings: 1

Open (1)

• Kubernetes runner Go image remains hard-coded and can go out of sync · New

What changed in this PR

Updates e2e Go-version selection and applies mechanical Go modernizations.

Changes:

• Parses go.mod to configure setup-go, preferring toolchain.
• Promotes golang.org/x/mod to a direct dependency.
• Uses modern range, maps, slices, strings, reflection, and any APIs.

File	Description
testing/​runtime/​runtime.go	Replaces interface{} with any.
testing/​kubectl.go	Uses strings.SplitSeq.
test/​e2e/​e2e_test.go	Reads the e2e setup-go version from go.mod.
logging/​transport.go	Replaces interface{} with any.
logging/​logger.go	Uses slices.Contains.
hash/​hash.go	Modernizes generic parameters to any.
hash/​fnv.go	Modernizes variadic parameters to any.
go.mod	Makes golang.org/x/mod direct.
controllers/​actions.github.com/​predicates_test.go	Uses reflect.Type.Fields.
controllers/​actions.github.com/​ephemeralrunnerset_controller_test.go	Uses range-over-int.
charts/​gha-runner-scale-set/​tests/​template_test.go	Uses maps.Copy.
charts/​gha-runner-scale-set-controller/​tests/​metrics_test.go	Uses strings.SplitSeq.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

The central toolchain-precedence behavior lacks focused automated coverage.

Review effort: Balanced
Findings: 1

Open (1)

• Add focused tests for toolchain precedence and go directive fallback · New

Resolved since last review (1)

• Kubernetes runner Go image remains hard-coded and can go out of sync

[nikola-jokic]

Looks good to me!