Repository navigation
Requeue instead of erroring when the recreated AutoscalingListener already exists - #4702
Open
CloudNinjaDev wants to merge 1 commit into
Open
CloudNinjaDev wants to merge 1 commit into
CloudNinjaDev wants to merge 1 commit into
Conversation
…ready exists After a runner template update the AutoscalingRunnerSet reconciler deletes the out-of-date listener and creates a new one. If the cache has not observed the previous object being replaced yet, Create returns AlreadyExists, which was logged as an error and counted in controller_runtime_reconcile_errors_total although the next reconcile recovers on its own. Treat AlreadyExists as a transient condition and requeue after a second, mirroring the handling of the ephemeral runner pod creation. Fixes actions#4698
CloudNinjaDev
requested review from
a team,
Steve-Glass,
mumoshu,
nikola-jokic,
rentziass and
toast-gear
as code owners
October 2, 2026 16:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4698.
When a runner template changes, the
AutoscalingRunnerSetreconciler deletes the out-of-date listener and creates a new one. If the cache has not yet observed the replacement,CreatereturnsAlreadyExists. That was logged as an error and returned, incrementingcontroller_runtime_reconcile_errors_total(and triggering alerts) even though the next reconcile recovers by itself.AlreadyExistsis now treated as transient: log at info level and requeue after one second. This mirrors the existing handling for ephemeral runner pod creation.Testing
Local run with envtest (k8s 1.37.0, go1.27.1):
The existing AutoscalingRunnerSet and AutoscalingListener suites pass with the change.