Skip to content

Support get manifest from local #463

@retzero

Description

@retzero

Description:
We ran into a rate limit issue while running our GitHub Enterprise Server instance.
There are several topics discussed below, but they are not suitable for us.
#219, #427, #316

The rate limit problem seems to be caused by importing the manifest file located on github.com.
Wouldn't the problem go away if the action import a local manifest file instead?

I suggest using a local file instead of calling the api to github.com if the hosted runner has a specific environment variable (eg, SETUP_PYTHON_MANIFEST_FILE_LOCATION).

https://github.com/actions/setup-python/blob/main/src/install-python.ts#L19

+ # pseudo code
+ if (SETUP_PYTHON_MANIFEST_FILE_LOCATION is set) {
+   const manifest: tc.IToolRelease[] = getManifestFromLocal(
+   ...
+ } else {
  const manifest: tc.IToolRelease[] = await tc.getManifestFromRepo(

Justification:
Justification or a use case for your proposal.

Are you willing to submit a PR?

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestNew feature or request to improve the current logic

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions