Repository navigation
fix(web): the fork's sidebar rows live in upstream's row files again - #464
Merged
Merged
Conversation
The fork kept its thread row, draft rows and list markers inline in Sidebar.tsx after upstream moved them to sidebar/SidebarThreadRow.tsx, SidebarDraftBlock.tsx and SidebarListMarkers.tsx. Those files went unused, so upstream fixes to them merged cleanly into dead code and never reached the fork. Move the fork's versions into those files, unchanged, and port the two upstream fixes that had landed only there: - Rows read their live thread shell over the sidebar's quiet list, so a streaming thread re-renders only its own row (pingdotgg#22730). - Thread titles, tab titles and the rename field read right to left for Arabic and Hebrew (pingdotgg#22777). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upstream moved the sidebar's thread row, draft rows and list markers out of
Sidebar.tsxintosidebar/SidebarThreadRow.tsx,SidebarDraftBlock.tsxandSidebarListMarkers.tsx(pingdotgg#22696, pingdotgg#22729). The fork kept its own versions inline, so those three files became dead code that nothing imported (knip's unused-files finding on #460). Upstream fixes made to them merged without conflicts and never reached the fork, which is how these two were missed:Fix
Sidebar.tsxand import from the new files. Future upstream edits to these files now merge into fork code or conflict visibly.SortableThreadRowandSidebarSearchResultRowread the live thread shell, as upstream's do. The fork's row also reads the live shell for the tab it displays.textDirection/dir="auto".Upstream row changes that were intentionally not ported:
compactSidebarTimeLabel: the fork keeps it inSidebarTabSummary.Verification
vp run check:changed: format, lint, typecheck (2 packages) and tests (3 files, 240 tests) pass. Knip's unused-files pass is now clean. The unused-exports pass still fails on 117 existing exports outside the sidebar, the same finding noted on chore: merge upstream/main into fork #460.🤖 Generated with Claude Code (Claude Opus 5.5, in T3 Code)