Conversation
Contributor
Mira PR WalkthroughWalkthrough was not generated. |
![not-adam[bot]](https://avatars.githubusercontent.com/in/4210289?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Mira Review Summary
The PR adds a comprehensive LLM-driven eval system (runner, fixtures, assertions, 5 scenarios, user-driver agent) with a publication gate in publish.yml. The primary concern is that the core runAgent orchestration in evals/runner.ts (888 lines) has no test coverage — the existing tests only cover helper functions, leaving the session lifecycle, timeout handling, credential isolation, replay logic, and budget enforcement untested. Since publication is gated on these evals passing, a runner bug could block valid releases or allow broken code through.
Key Issues
| Issue | Location | |
|---|---|---|
| 🔴 | The eval runner (888 lines) that gates npm publication has no test coverage for its core orchestration logic. Bugs in session lifecycle, timeout handling, or credential isolation could cause false pass/fail in publication gating. | evals/runner.ts:1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.