Skip to content

Improve evals. - #72

Merged
adampoit merged 2 commits into
mainfrom
eval-improvements
Aug 7, 2026
Merged

Improve evals.#72
adampoit merged 2 commits into
mainfrom
eval-improvements

Conversation

@adampoit

@adampoit adampoit commented Aug 7, 2026

Copy link
Copy Markdown
Owner
  • Improve skills based on evals.
  • Move evals to gate draft-release.

@not-adam

not-adam Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Mira PR Walkthrough

This PR overhauls the eval infrastructure by extracting scenario intent contracts into immutable JSON files (evals/intents/*.json), isolating the synthetic user-driver policy into protected templates (evals/user-driver/*.md), and enforcing contract integrity through a local Pi extension guard (eval-intent-guard.ts), CI checks (evals:contracts), and comprehensive tests. It simultaneously improves Patchlane worker skills (fork-setup, workspace, sync-patches, health-check, migration) to carry workflow requirements rather than embedding them in driver prompts or scenario code. The release pipeline is restructured to move live eval gating from publish.yml into draft-release.yml.

graph LR
    intent["evals/intents/*.json"]
    ud["evals/user-driver/*.md"]
    guard[".pi/extensions/eval-intent-guard.ts"]
    skills["skills/*/SKILL.md"]
    ci[".github/workflows/ci.yml"]
    draft[".github/workflows/draft-release.yml"]

    intent -->|"loaded & validated by"| guard
    ud -->|"protected by"| guard
    guard -->|"enforced in CI via"| ci
    guard -->|"gated on draft release via"| draft
    skills -->|"carry workflow rules for"| intent
    ci -->|"contract hash check"| intent
    ci -->|"contract hash check"| ud
Loading
Confidence: 4/5   ◉◉◉◉○   Safe with minor fixes
  • The extensiveness and structural soundness of tests, CI gating, and contract integrity checks make this PR well-defended, but the large number of changed files (38) and deep refactoring across eval scenarios, runner logic, and skill definitions warrants careful review—particularly for unintended behavioral drift in assertions, backward compatibility of transcript parsing, and any edge cases in the Pi extension shell command classification.

Blast Radius — 2 dependent repositories, 3 total references

adampoit/mira — 1 reference
adampoit/wezterm — 2 references

42 files reviewed


Comment @not-adam help to get the list of available commands and usage tips.

@adampoit
adampoit merged commit 6da4493 into main Aug 7, 2026
2 checks passed
@adampoit
adampoit deleted the eval-improvements branch August 7, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant