Repository navigation
Password component - #2000
Open
shravani-0811 wants to merge 7 commits into
Open
Password component #2000shravani-0811 wants to merge 7 commits into
shravani-0811 wants to merge 7 commits into
Conversation
Accessibility Violations Found
|
Accessibility Violations Found
|
4 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Sep 30, 2026
github-actions
Bot
force-pushed
the
password-component-clean
branch
from
October 1, 2026 03:57
23f8023 to
93a31a0
Compare
armaang1729
reviewed
Oct 1, 2026
| cssProcessor="[default:none,min:none]" | ||
| jsProcessor="[default:none,min:none]" | ||
| categories="[core.forms.components.runtime.all.xfa]" | ||
| embed="[core.forms.components.runtime.base.xfa,core.forms.components.container.v2.runtime,core.forms.components.datePicker.v1.runtime,core.forms.components.textinput.v1.runtime,core.forms.components.numberinput.v1.runtime,core.forms.components.panelcontainer.v1.runtime,core.forms.components.radiobutton.v2.runtime,core.forms.components.text.v1.runtime,core.forms.components.checkboxgroup.v2.runtime,core.forms.components.button.v1.runtime,core.forms.components.image.v1.runtime,core.forms.components.dropdown.v1.runtime,core.forms.components.fileinput.v3.runtime,core.forms.components.accordion.v1.runtime,core.forms.components.tabs.v1.runtime,core.forms.components.wizard.v1.runtime,core.forms.components.verticaltabs.v1.runtime,core.forms.components.recaptcha.v1.runtime,core.forms.components.checkbox.v1.runtime,core.forms.components.fragment.v1.runtime,core.forms.components.switch.v1.runtime,core.forms.components.termsandconditions.v1.runtime, core.forms.components.hcaptcha.v1.runtime,core.forms.components.review.v1.runtime, core.forms.components.turnstile.v1.runtime]"/> |
Collaborator
There was a problem hiding this comment.
Why is passwordinput.v1.runtime added to runtime-all-xfa?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new **Adaptive Form Password Input ** core component: a masked field with an optional show/hide visibility toggle button.
Related Issue
Motivation and Context
Adaptive Forms didn't have a first-class password field: authors had to repurpose Text Input, which offers no masking, no visibility toggle, and no autofill-attribute control suited to credentials. This adds that as a proper, accessible core component while closing off the plaintext-exposure trap that comes from naively inheriting Text Input's "default value" behavior for a password-typed field.
How Has This Been Tested?
TextInputImplTest): field type resolution (fieldType=password→getFieldType()/getExportedType()),isShowHidePasswordEnabled()default-true and author-disabled cases, and.model.jsonexport shape viatestJSONExport.passwordinput.authoring.cy.js): dropping the component into a form container / responsive grid via the editor sidebar, and opening its edit dialog.passwordinput.runtime.cy.js): model/view initialization, masked-by-default rendering, clicking the eye icon reveals plaintext and togglesaria-pressed/aria-label(and back), toggle button absent whenshowHidePasswordis disabled, value submits correctly regardless of toggle state, minLength/mandatory validation messages, description/tooltip toggling, andaria-disabledabsence when disabled.aria-pressedflips) in the disabled/preview rendering path.Screenshots (if appropriate):
Types of changes
Checklist: