benchmarking: expand cAdvisor scrape allowlist for kernel PSI, networ… - #1599
Open
Nishanth Kotla (Nishanth29) wants to merge 1 commit into
Open
benchmarking: expand cAdvisor scrape allowlist for kernel PSI, networ…#1599Nishanth Kotla (Nishanth29) wants to merge 1 commit into
Nishanth Kotla (Nishanth29) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1588
What this PR does
This PR updates the Prometheus cAdvisor scrape configuration in
benchmarking/monitoring.yamlto retain Linux kernel Pressure Stall Information (PSI), network bandwidth, disk I/O throughput, and host-level node resource utilization.Problem
Currently,
monitoring.yamlrestricts cAdvisor scrapes to only:container_(memory_working_set_bytes|cpu_usage_seconds_total|spec_memory_limit_bytes)and unconditionally drops series with
container="".Because cAdvisor reports the host root cgroup (
id="/") with an empty container label, this configuration strips:cpu.pressure,io.pressure,memory.pressure).containerd,kubelet, virtualization runtime).container_network_*) and disk I/O (container_fs_*).Under high-density multi-tenant agent benchmarks, diagnosing whether tail latency spikes stem from CPU scheduling contention, disk storage bottlenecks, or memory pressure is difficult without kernel PSI.
Proposed Changes
In
benchmarking/monitoring.yaml:id="/"tocontainer="node"before dropping empty container labels, preserving host-level node rollups.container_pressure_*(Linux PSI),container_network_*,container_fs_*,container_cpu_cfs_*, andcontainer_memory_rss.How this was tested
Tested on a benchmark cluster running the
gluttonuser workload:Verified that
container_pressure_*metrics (CPU, memory, and I/O) are actively collected and queryable in Prometheus.Verified that host-level root cgroup metrics appear under
container="node".Verified that container network and filesystem I/O metrics are retained, while pod-level duplicate CPU and memory working-set series are dropped as intended.
Tests pass
Appropriate changes to documentation are included in the PR