benchmark: Make nighthawk more reproducible and add agentgateway - #1628
Draft
Keith Mattix II (keithmattix) wants to merge 3 commits into
Draft
Keith Mattix II (keithmattix) wants to merge 3 commits into
Keith Mattix II (keithmattix) wants to merge 3 commits into
Conversation
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Keith Mattix II (keithmattix)
force-pushed
the
nighthawk-agentgateway
branch
from
September 12, 2026 19:33
a57dca6 to
3b865f5
Compare
Collaborator
There was a problem hiding this comment.
Update: The ingress-contract portion of this review and three related inline comments have been moved to #1598, where those changes originate. The benchmark-specific questions remain here. The CI matrix suggestion is already addressed in #1598.
Original review:
Overall adding these changes make sense to me but I have some clarifying questions about some language and about what the actual ingress contract is since there are definitely dataplane specific checks in the tests
| dataplane = nh["dataplane"] | ||
| cpu_key = "envoyCpu" if dataplane == "envoy" else "agentgatewayCpu" | ||
| cpu = str(nh[cpu_key]) | ||
| if dataplane == "agentgateway": |
Collaborator
There was a problem hiding this comment.
Switch statement here, does python even have one? 😆
Collaborator
Author
There was a problem hiding this comment.
Very very recently according to Google; I've never used it though
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AgentGateway support to the Nighthawk ingress-capacity benchmark and make the comparison reproducible on GKE. Stacked on top of #1598.