Repository navigation
[WIP][Stack on #1730] Use ActorDirs in ateom-gvisor/ateom-microVM and remove ateompath - #1842
Closed
Haven Xia (HavenXia) wants to merge 4 commits into
Closed
Haven Xia (HavenXia) wants to merge 4 commits into
Haven Xia (HavenXia) wants to merge 4 commits into
Conversation
atelet and both ateoms derive the per-actor directories (bundles, runsc state, pid files, checkpoint and restore state, durable-dir, system-info and CSI volume roots) from the actor UID through the same package, internal/ateompath. Add an ActorDirs message to RunWorkloadRequest, RestoreWorkloadRequest, CheckpointWorkloadRequest and TerminateWorkloadRequest, and have atelet fill it with the directories it prepared.
Haven Xia (HavenXia)
force-pushed
the
ateom-read-actor-dirs
branch
from
September 24, 2026 00:41
909edcf to
c219cc3
Compare
Haven Xia (HavenXia)
changed the title
- cmd/atelet/internal/ateletpath: atelet's on-node pathes, the per-actor directories it prepares (and ActorDirs, built from them) plus the node-level directories only atelet uses. - internal/nodepath: what both sides need before the first RPC, the host directory they mount and the sockets and netns they find each other by. atecontroller renders the worker pod's hostPath from it. - internal/ateompath: only what the ateoms still uses it self.
Haven Xia (HavenXia)
force-pushed
the
ateom-read-actor-dirs
branch
from
September 24, 2026 01:07
c219cc3 to
34f0383
Compare
Haven Xia (HavenXia)
changed the title
innaveli4k-lab
approved these changes
Sep 24, 2026
innaveli4k-lab
approved these changes
Sep 24, 2026
Member
Author
|
close to sperate into two prs |
This comment was marked as spam.
This comment was marked as spam.
Bowei Du (bowei)
added
kind/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1730 adds
ActorDirsto the ateom RPCs and has atelet fill it. This PR makes both ateoms uses the paths from RPC, so no need to computes per-actor paths from the actor UID anymore.Everything else ateom needs under the actor is built from these directories too:
ShapeMicroVMuses the entireActorDirs, and the two paths ateom keeps for itself,rootfs-upper(micro-VM) and the sandboxresolv.conf(gVisor), use theActorDirs.root_dir.Validation:
A request whose
ActorDirsis missing, relative, or outsideroot_diris rejected withInvalidArgumentbefore anything runs.Part of #1604.