Repository navigation
ateom-gvisor: take the actor directories from the request - #1865
Merged
Benjamin Elder (BenTheElder) merged 2 commits intoSep 28, 2026
Merged
Benjamin Elder (BenTheElder) merged 2 commits into
Benjamin Elder (BenTheElder) merged 2 commits into
Conversation
Haven Xia (HavenXia)
force-pushed
the
ateom-gvisor-dirs
branch
4 times, most recently
from
September 25, 2026 21:38
6b7854d to
3b9b7bb
Compare
Haven Xia (HavenXia)
marked this pull request as ready for review
September 25, 2026 21:39
Haven Xia (HavenXia)
changed the title
Haven Xia (HavenXia)
force-pushed
the
ateom-gvisor-dirs
branch
from
September 28, 2026 16:25
3b9b7bb to
c86a0af
Compare
Haven Xia (HavenXia)
force-pushed
the
ateom-gvisor-dirs
branch
from
September 28, 2026 18:27
c86a0af to
5b8ce95
Compare
| // durableTarFile is the snapshot file holding the tar of the actor's durable-dir | ||
| // volumes. Its entries are <volumeName>/... relative to | ||
| // ateompath.DurableDirVolumeMountsDir, so extraction restores the same layout. | ||
| // ActorDirs.durable_dir_volume_mounts_dir, so extraction restores the same layout. |
Collaborator
There was a problem hiding this comment.
still TODO to stop sharing this info entirely.
Benjamin Elder (BenTheElder)
approved these changes
Sep 28, 2026
Merged
via the queue into
agent-substrate:main
with commit Sep 28, 2026
7380e23
10 of 11 checks passed
Bowei Du (bowei)
added
area/node
kind/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR let ateom-gvisor reads the per-actor directories from the
ActorDirs(added in #1730) in the request instead of deriving them from the actor UID.The paths
ateom-gvisorstill builds itself are put into gvisor specificcmd/ateom-gvisor/actorpath.go.Resetting
runsc-stateandpidfilesmoves from atelet'sresetActorDirsto ateom-gvisor'smain.goto conduct at beginning ofRunWorkloadandRestoreWorkload, which empties them at the start of Run and Restore. Atelet doesn't actually read them, so #1730 drops them fromActorDirs.Added a new
ActorDirsvalidation to reject a request withInvalidArgumentwhenActorDirsis missing or any directory in it is empty, relative or unclean.The gVisor paths are removed from
internal/ateompath; the rest goes with ateom-microvm in the next PR.Part of #1604.