Repository navigation
Make atelet.Terminate idempotent and write the sandbox record before Restore calls ateom - #1884
Closed
Luiz Oliveira (laoj2) wants to merge 1 commit into
Closed
Luiz Oliveira (laoj2) wants to merge 1 commit into
Luiz Oliveira (laoj2) wants to merge 1 commit into
Conversation
Luiz Oliveira (laoj2)
commented
Sep 25, 2026
Luiz Oliveira (laoj2)
commented
Collaborator
- We need to write the sandbox record before Restore calls ateom, otherwise a partially failed Restore can leave an orphaned sandbox that can't be cleaned up by Terminate
- Terminate now only skips the terminateWorkload call to ateom if it doesn't found the sandbox record, but still deregister system volumes, unmount external volumes and cleans up the snapshot and actor dirs.
Luiz Oliveira (laoj2)
requested review from
Dmitry Berkovich (dberkov) and
Zoe Zhao (zoez7)
September 25, 2026 16:40
Collaborator
Author
|
Talked to Zoe Zhao (@zoez7) and shrutiyam-glitch. Instead of handling failed reads to SandboxRecord, we'll send the sandbox assets in the requests to atelet.Terminate and reject the request if sandbox_assets is unset. So, we won't need this PR |
Bowei Du (bowei)
added
area/node
area/reliability
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.