Repository navigation
Align timestamp fields with AIP-142 naming conventions - #2438
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the first contribution! It looks like you need to to sign a Contributor License Agreement. Please also rebase on main and fix conflicts. |
…ield-names # Conflicts: # cmd/ateapi/internal/controlapi/template_reconciler_test.go # pkg/proto/ateapipb/ateapi.pb.go
…ield-names # Conflicts: # pkg/proto/ateapipb/ateapi.pb.go
Thanks Julian Gutierrez Oschmann (@juli4n). Signed the CLA, rebased and fixed conflicts. |
…ield-names # Conflicts: # cmd/ateapi/internal/controlapi/actor.go # cmd/atenet/internal/router/egress/actorjwt/actorjwt_test.go # cmd/atenet/internal/router/egress/egress_test.go # pkg/proto/ateapipb/ateapi.pb.go
Summary
Align the two remaining nonconforming public Timestamp field names with the
API's AIP naming conventions:
MintActorJwtResponse.expires_atbecomesexpire_time.GoldenSnapshotStatus.take_golden_snapshot_atbecomessnapshot_time.Update in-repository callers and existing tests, regenerate protobuf and
declarative validation code, and document the
_timenaming rule. Retain theexisting validation, lifecycle, and JWT functional coverage; the additional
protobuf serialization test file has been removed.
Fixes #2415.
Breaking change
Regenerate clients and update references to these fields:
expires_at/expiresAtexpire_time/expireTimetake_golden_snapshot_at/takeGoldenSnapshotAtsnapshot_time/snapshotTimeExpiresAt/GetExpiresAt()ExpireTime/GetExpireTime()TakeGoldenSnapshotAt/GetTakeGoldenSnapshotAt()SnapshotTime/GetSnapshotTime()Timestamp semantics, types, and protobuf field numbers are unchanged. Old-name
aliases are not retained, following the project's pre-1.0 compatibility policy.
Please apply the
breaking-changelabel.Verification
TestMintActorJWTthrough the functional API harness.hack/verify-all.sh: all 15 current repository verifiers passed on the latest conflict refresh.CI follow-up
The October 12 E2E failure was two timeouts to public
httpbin.orgin thecredential-injection suite. Current
mainincludes #2535, which replaces thatexternal origin with an in-cluster echo server and restores the test after the
earlier upstream quarantine. This PR adds no test skip of its own.
Contribution note
This is a first contribution, opened as a draft for coordination and feedback.
GitHub Copilot CLI was used to help prepare the code, tests, and PR description.