Repository navigation
Rename the snapshot-plugin sidecar, image and flag to objectstore-plugin - #2540
Merged
Haven Xia (HavenXia) merged 1 commit intoOct 13, 2026
Conversation
The plugin now serves sandbox assets as well as snapshots, and its API is already objectstore.v1, so name the binary, sidecar and flags after it. BREAKING CHANGE: the cmd/snapshot-plugin image is now cmd/objectstore-plugin, the snapshot-plugin sidecar container and volume in atelet and ate-api-server are now objectstore-plugin, the sockets move from /run/snapshot-plugin to /run/objectstore-plugin, and the --snapshot-plugin-socket flag on atelet and ate-api-server is now --objectstore-plugin-socket. Overlays that patch the snapshot-plugin container or pass the old flag must be updated.
Anish Ramasekar (aramase)
force-pushed
the
aramase/c/rename_objectstore_plugin
branch
from
October 13, 2026 01:22
9ba3357 to
fd6b68d
Compare
Anish Ramasekar (aramase)
marked this pull request as ready for review
October 13, 2026 01:23
Collaborator
Author
ILLUM1N0X
approved these changes
Oct 13, 2026
Michelle Au (msau42)
approved these changes
Oct 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2026
Collaborator
Author
|
Michelle Au (@msau42) this needs to be added to the merge queue again. |
Fluct (f1luct)
approved these changes
Oct 13, 2026
Anish Ramasekar (aramase)
deleted the
aramase/c/rename_objectstore_plugin
branch
October 13, 2026 03:48
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin now serves sandbox assets as well as snapshots, and its API is already
objectstore.v1, so the namesnapshot-pluginno longer describes it. This renames the binary, sidecar, sockets and flag to match. Theobjectstore.v1proto package and RPC names are unchanged.cmd/snapshot-pluginmoves tocmd/objectstore-plugin; the atelet and ate-api-server manifests and the kind overlays follow.--snapshot-plugin-socketbecomes--objectstore-plugin-socketon atelet and ate-api-server, with no alias.docs/architecture.mdandhack/verify/ateapi-deps.shnow say "object-store plugin".Breaking change
The
cmd/snapshot-pluginimage is nowcmd/objectstore-plugin, thesnapshot-pluginsidecar container and volume in atelet and ate-api-server are nowobjectstore-plugin, the sockets move from/run/snapshot-pluginto/run/objectstore-plugin, and the--snapshot-plugin-socketflag on atelet and ate-api-server is now--objectstore-plugin-socket. The sidecars' traceservice.namechanges fromsnapshot-plugin-<mode>toobjectstore-plugin-<mode>. Overlays that patch thesnapshot-plugincontainer, pass the old flag or filter on the old service name must be updated.Needs the
breaking-changelabel.Tested with
go build ./...,go test -raceon cmd/ateapi, cmd/atelet, cmd/objectstore-plugin, cmd/ate-setup, internal/objectstoreplugin and internal/pluginsocket, andhack/verify/ateapi-deps.sh. The base, kind, kind-agentgateway and agentgateway kustomize renders differ from before only by the rename.