Repository navigation
fix: strip leaked e2e/node_modules symlink - #46
Merged
Merged
Conversation
PR #45 accidentally committed e2e/node_modules as a mode-120000 symlink pointing at /a0/usr/workdir/.bdd-deps/node_modules -- a machine-local dep cache path that exists on exactly one machine. Every clone would carry a dangling symlink. .gitignore already had 'node_modules/', but the trailing slash matches only real DIRECTORIES, so a symlink of the same name slips past. Added a bare 'node_modules' pattern alongside it so this cannot recur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #45 accidentally committed
e2e/node_modulesas a mode-120000 symlink to/a0/usr/workdir/.bdd-deps/node_modules— a machine-local path. Every clone gets a dangling symlink..gitignorehadnode_modules/, but the trailing slash matches only real directories, so a symlink of the same name slipped past. Added a barenode_modulespattern.git rm --cached e2e/node_modules