Repository navigation
fix(ci): check out the devkit in upstream-compat, not just the plugin - #61
Merged
Merged
Conversation
First real run failed on all four legs with context must be a directory: .../devcontainer The compat job checked out the plugin into plugin/ but never checked out the devkit itself, so devcontainer/Containerfile — which the harness build references relative to the workspace root — was simply not there. This is the exact path the author flagged as untested, since it differs from the proven plugin-e2e.yml body. Order matters: a checkout without `path` cleans the workspace, so the devkit must be fetched BEFORE the plugin is placed in plugin/, or it deletes it. Worth noting the design held: the report job FAILED loudly rather than reporting a vacuous pass, which is precisely the guard that DEC-079 nightly lacked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first real run of
upstream-compatfailed on all four legs:The
compatjob checked out the plugin intoplugin/but never checked out the devkit itself, sodevcontainer/Containerfile— referenced relative to the workspace root by the harness build — was not there.This is exactly the path flagged as untested when the workflow was written, because it runs in the devkit's workspace rather than the consumer's and so differs from the proven
plugin-e2e.ymlbody.Order matters: a checkout without
pathcleans the workspace, so the devkit must be fetched before the plugin is placed inplugin/, or it would delete it.The design held
The four failures were not plugin failures — the same four plugins passed against upstream in their own PRs minutes earlier. The report job failed loudly rather than reporting a vacuous pass, which is precisely the guard the deleted DEC-079 nightly lacked. A broken harness looked like a broken harness.
Re-dispatching after merge to prove the fix rather than assume it.