-
Notifications
You must be signed in to change notification settings - Fork 45
feat(sdk): out of box controls - part 2 #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
namrataghadi-galileo
wants to merge
26
commits into
main
Choose a base branch
from
feature/67101-out-of-box-controls-phase-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c99a385
add out of hte box controls
namrataghadi-galileo 51d1a12
phase 2 add controls
namrataghadi-galileo e6de28e
fix tests
namrataghadi-galileo e6eba19
fix lazy controls attachment to namespace
namrataghadi-galileo 9ecd541
fix tests
namrataghadi-galileo 37e6f59
create controls when controls tab is clicked
namrataghadi-galileo c6aae0a
show for clone=false
namrataghadi-galileo 0e3972a
Merge branch 'main' into feature/67101-out-of-box-controls
namrataghadi-galileo 54c06d8
address comments
namrataghadi-galileo cd94f03
Merge branch 'main' into feature/67101-out-of-box-controls-phase-2
namrataghadi-galileo c624910
resolve merge conflicts
namrataghadi-galileo e954f9e
address comments and coverage
namrataghadi-galileo 7f3c6be
fix ts sdk
namrataghadi-galileo dfb129e
address comments
namrataghadi-galileo a64020b
address P2 comments
namrataghadi-galileo faddb0a
Merge branch 'feature/67101-out-of-box-controls' into feature/67101-o…
namrataghadi-galileo f94d14c
address comments
namrataghadi-galileo ebd68dd
address comments
namrataghadi-galileo 8378688
address comments
namrataghadi-galileo 46362d7
coverage
namrataghadi-galileo deb2ec6
resolve conflicts
namrataghadi-galileo 1b3dfe7
more comments
namrataghadi-galileo 7707cf7
more comments
namrataghadi-galileo 831a296
merge from main
namrataghadi-galileo 6d4da85
claude review
namrataghadi-galileo b30910e
ruff
namrataghadi-galileo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Preserve the existing wildcard payload shape
select_data(step, "*")dumps the whole model, so current tool integrations now addcanonical_nameto every wildcard evaluation. Existing JSON controls withadditionalProperties: falsechange from non-match to match and can deny previously valid calls; exclude this field from the legacy*view or version that selector shape.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The * selector now excludes canonical_name, preserving its existing payload contract for strict JSON controls. The field remains available through the explicit canonical_name selector. Added unit coverage and an E2E regression using additionalProperties: false.