Repository navigation
build: move the Go toolchain to 1.26 - #32
Merged
Merged
Conversation
The dependency update in #14 raised go.mod to go 1.26.0, because golang.org/x/{net,sys,text,oauth2,sync} and grpc v1.85.0 now require Go 1.26. mise still installed Go 1.25.14, so the compiler rejected the standard library ("version go1.26.0 does not match go tool version go1.25.14") and ci has failed on main since. Pin Go 1.26.11, the latest 1.26 patch release, and state the new minimum in the README and the getting-started guide. Holding the dependencies back instead is not an option: Go 1.25 is out of support now that 1.27 is out, and the x/ modules follow the two supported releases. Signed-off-by: Roland Huß <rhuss@redhat.com>
SDAChess
approved these changes
Nov 10, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #14,
cifails onmain:golang.org/x/{net,sys,text,oauth2,sync}andgrpcv1.85.0 require Go 1.26, sogo.modmoved togo 1.26.0, while mise still installs Go 1.25.14 and the compiler rejects the standard library (version "go1.26.0" does not match go tool version "go1.25.14"). This pins Go 1.26.11 and states the new minimum in the README and the getting-started guide.Holding the dependencies back is not an option: Go 1.25 is out of support since 1.27, and the x/ modules follow the two supported releases. Core already builds with Go 1.26.7.
This needs to land before core v0.1.8: the stable proposal that core-watch opens would otherwise fail
ci, and the SDK v0.1.8 tag follows its merge.Testing:
mise run cipasses locally with Go 1.26.11 (lint,proto:check,conformance:check, tests with-race).