Skip to content

Optional dark background for HTML view - #140

Merged
laarmen merged 2 commits into
akissinger:masterfrom
laarmen:background-html-fix
Oct 20, 2026
Merged

laarmen merged 2 commits into
akissinger:masterfrom
laarmen:background-html-fix

Conversation

@laarmen

@laarmen laarmen commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

We broke HTML view a little bit when I merge #135 as it takes on the new background color but keeps a dark text.

This fixes it in two manners:

  • We can use the built-in dark mode for the HTML view
  • We change the background color more selectively

laarmen added 2 commits July 1, 2026 14:42
We still need the background toggling because even in dark mode it'll
use a white background when there is no content.
In akissinger#135 we forced the background color to the theme one for the email
body view to avoid a white flash when first entering a thread view
before it switches to plain text view.

However, it kinda broke the HTML view as most emails out there assume a
default white background, making them unreadable if you're using a dark
theme.
@laarmen
laarmen merged commit 5bf9031 into akissinger:master Oct 20, 2026
@laarmen
laarmen deleted the background-html-fix branch October 20, 2026 08:17
@laarmen
laarmen restored the background-html-fix branch October 20, 2026 08:18
@laarmen
laarmen deleted the background-html-fix branch October 20, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants