docs(proposals): add Atlas Design System skill proposal - #14
Merged
Conversation
Land the atlas-design proposal — a taste + workflow skill layer that makes mxcli-generated Mendix apps look designed by default (the Atlas-first method, 4-layer token architecture, recipe library, chart/dark-mode widget recipes, a gotchas catalog, and a mandatory runtime-verify loop). It sits on top of the page-styling, page-composition, building-blocks, and page-templates proposals and consumes what they build rather than duplicating them. Drafted from the Itinera / Atlas-MES build (test app ako/MxcliTest1). Two corrections vs the original draft, verified against the codebase: - all chart types (incl. Line/Bubble/Heatmap/TimeSeries) are MDL-authorable today; the "stick to the authorable four" note was stale. - the two P0 warm-loop tooling bugs it listed are now fixed (PR #13), so those rows are marked done. Regenerates the proposals README index. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnEgoc2NQP1Y2TWMCMXC4
ako
pushed a commit
that referenced
this pull request
Jul 29, 2026
…c sugar, ADD doc (FINDINGS #3/#5/#13/#14/#4) Five surprising parser rejects / silent-wrong writes where quoting or a keyword behaved inconsistently with the rest of MDL: - #3 index name can't be quoted: indexDefinition accepted only IDENTIFIER for the name → `index "idx_x" (Col)` was a parse error. Accept QUOTED_IDENTIFIER too (the name is advisory and discarded, as before). - #5 role-name quoting inconsistent: DESCRIBE USER ROLE required quotes, DROP USER ROLE rejected them. Both now accept bare and quoted names; visitors handle both. - #13 `sort by` quoted attribute stored a nonsense reference: a quoted qualified attribute (`sort by "Mod"."Entity"."Code"`) kept the quotes and only failed on write ("attribute does not belong to entity"). buildSortColumnMicroflow now unquotes each segment (bare dotted form), matching the SORT() list-op path. - #14 `DataSource: ASSOCIATION $currentObject/…` didn't parse (keyword + sugar were mutually exclusive). Added the combined grammar branch; the existing VARIABLE&&SLASH visitor branch already handles it correctly. - #4 doc: MDL spec README showed `alter entity … add (Attr: type)`, which the parser rejects. Corrected to `add attribute Attr: type`. Grammar regenerated (`make grammar`). Verified end to end: quoted index name, quoted qualified sort stored as `M.Thing.Code`, describe/drop role in both forms, and `ASSOCIATION $currentObject/…` all parse/store correctly. Tests added. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnEgoc2NQP1Y2TWMCMXC4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the
atlas-designproposal indocs/11-proposals/— a taste + workflow skill layer that makes mxcli-generated Mendix apps look designed by default (the wayartifact-designdoes for HTML anddatavizdoes for charts). Drafted from the Itinera / Atlas-MES build (test appako/MxcliTest1).What the proposal covers
.mdlfill-in today, migrating to parameterized fragments /use building block).dataviz-grade chart theme (transparent PlotlycustomLayout+displayModeBar:false+ per-typecustomSeriesOptions) and an optional dark-mode Atlas-widget override recipe.It explicitly defers to the
page-styling-support,proposal_page_composition,show-describe-building-blocks, andshow-describe-page-templatesproposals rather than duplicating them.Corrections vs the original draft (verified against the codebase)
mdl-examples/doctype-tests/34-chart-widget-examples.mdl). The draft's "stick to the authorable four" was stale; corrected, and a P2 doc task added to fix the matchingcreate-page.mdnote./dist/index.js404; stray serve holding the port) are now fixed in PR fix(run): warm-loop reliability — re-serve client bundle on structural change + reap child process groups #13, so those rows are marked ✅.file/symbol evidence.Notes
scripts/gen_proposals_readme.py), which now lists it as Proposed (84 active).🤖 Generated with Claude Code
https://claude.ai/code/session_01JXnEgoc2NQP1Y2TWMCMXC4
Generated by Claude Code